Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Modules fail linting on pipeline integration #89

Open
nikhil opened this issue Apr 18, 2024 · 3 comments
Open

Modules fail linting on pipeline integration #89

nikhil opened this issue Apr 18, 2024 · 3 comments

Comments

@nikhil
Copy link
Collaborator

nikhil commented Apr 18, 2024

When we load modules into a pipeline we fail the linting pr-commit checks even though it passed all the linting checks on the module level.

See this for an example: https://github.com/mskcc/NeoAntigen-Pipeline/actions/runs/8622226575/job/23632903027

This is probably because nf-core pipelines ship with a default .editorconfig and we don't have that check on module integration

Probably related to, and possibly fixed by #87

@buehlere
Copy link
Collaborator

I had this issue as well.

@anoronh4
Copy link
Collaborator

i think you should be able to merge changes from #88 into your dev branch, fix the resulting linting errors and then re-install the modules in your pipeline. you may have to manually run the linting in your branch as i don't think the repo is set up to automatically trigger linting when you're not making a PR to develop or main.

@anoronh4
Copy link
Collaborator

anoronh4 commented Apr 30, 2024

i am unfortunately STILL getting some issues with editorconfig in my pipeline, although most are cleaned up. i am making the following modification to my pipeline to make sure installed modules don't cause issues:

https://github.com/mskcc/forte/blob/e826931ad188b33e58febc2a8539bd6757e20399/.editorconfig#L15

i think it makes more sense to just filter these files from the editorconfig check anyways because it's not the responsibility of my pipeline to lint installed modules -- it should be linted in the modules repo.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants