New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

New release for cacheControl option? #63

Open

JoakimLofgren opened this issue Mar 29, 2019 · 2 comments

Labels

Milestone

JoakimLofgren commented Mar 29, 2019

Hi,

I tried to use the cacheControl option to specify how long my assets should be cached, but it doesn't seem to be included in the 3.0.0 release.

E.g. I can't find these lines when I bumped to 3.0.0:
https://github.com/multiplegeorges/vue-cli-plugin-s3-deploy/blob/master/s3deploy.js#L201-L203

Could you do a new release ?

Collaborator

nicekiwi commented Apr 25, 2019

cacheControl.. isn't that handled by S3 directly?

Author

JoakimLofgren commented Apr 25, 2019

AFAIK you still need to set the metadata on the objects uploaded to S3.

See:
https://docs.aws.amazon.com/AmazonCloudFront/latest/DeveloperGuide/Expiration.html#expiration-individual-objects
https://docs.aws.amazon.com/AmazonCloudFront/latest/DeveloperGuide/Expiration.html#ExpirationAddingHeadersInS3

nicekiwi added this to the 3.1.0 milestone

nicekiwi added the enhancement label

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment