From 32557a0d643f001a4db06edc5f697386b494685e Mon Sep 17 00:00:00 2001
From: Matijs van Zuijlen <matijs@matijs.net>
Date: Wed, 27 Feb 2019 08:57:07 +0100
Subject: [PATCH] Update RuboCop TODO file

---
 .rubocop_todo.yml | 58 ++++++++++++++++++++---------------------------
 1 file changed, 25 insertions(+), 33 deletions(-)

diff --git a/.rubocop_todo.yml b/.rubocop_todo.yml
index a3c858a1..0293409b 100644
--- a/.rubocop_todo.yml
+++ b/.rubocop_todo.yml
@@ -1,24 +1,22 @@
 # This configuration was generated by
 # `rubocop --auto-gen-config`
-# on 2019-10-05 21:03:46 +0200 using RuboCop version 0.75.0.
+# on 2019-10-16 21:36:20 +0200 using RuboCop version 0.75.1.
 # The point is for the user to remove these configuration records
 # one by one as the offenses are removed from the code base.
 # Note that changes in the inspected code, or installation of new
 # versions of RuboCop, may require this file to be generated again.
 
-# Offense count: 3
-# Cop supports --auto-correct.
-# Configuration parameters: IndentationWidth.
-Layout/IndentAssignment:
-  Exclude:
-    - 'lib/alexandria/ui/ui_manager.rb'
-
 # Offense count: 2
 Lint/IneffectiveAccessModifier:
   Exclude:
     - 'lib/alexandria/logging.rb'
     - 'lib/alexandria/web_themes.rb'
 
+# Offense count: 1
+Lint/ShadowingOuterLocalVariable:
+  Exclude:
+    - 'lib/alexandria/ui/libraries_combo.rb'
+
 # Offense count: 1
 Lint/UriEscapeUnescape:
   Exclude:
@@ -30,9 +28,9 @@ Lint/UselessAccessModifier:
   Exclude:
     - 'lib/alexandria/logging.rb'
 
-# Offense count: 162
+# Offense count: 163
 Metrics/AbcSize:
-  Max: 161
+  Max: 160
 
 # Offense count: 21
 # Configuration parameters: CountComments, ExcludedMethods.
@@ -40,7 +38,7 @@ Metrics/AbcSize:
 Metrics/BlockLength:
   Max: 66
 
-# Offense count: 8
+# Offense count: 7
 # Configuration parameters: CountBlocks.
 Metrics/BlockNesting:
   Max: 5
@@ -48,9 +46,9 @@ Metrics/BlockNesting:
 # Offense count: 32
 # Configuration parameters: CountComments.
 Metrics/ClassLength:
-  Max: 985
+  Max: 1006
 
-# Offense count: 65
+# Offense count: 64
 Metrics/CyclomaticComplexity:
   Max: 22
 
@@ -62,9 +60,9 @@ Metrics/MethodLength:
 # Offense count: 1
 # Configuration parameters: CountComments.
 Metrics/ModuleLength:
-  Max: 338
+  Max: 340
 
-# Offense count: 10
+# Offense count: 11
 # Configuration parameters: CountKeywordArgs.
 Metrics/ParameterLists:
   Max: 7
@@ -141,7 +139,8 @@ RSpec/ExampleLength:
     - 'spec/alexandria/export_library_spec.rb'
     - 'spec/alexandria/library_spec.rb'
     - 'spec/alexandria/library_store_spec.rb'
-    - 'spec/alexandria/ui/dialogs_spec.rb'
+    - 'spec/alexandria/ui/provider_preferences_dialog_spec.rb'
+    - 'spec/alexandria/ui/smart_library_properties_dialog_spec.rb'
     - 'spec/end_to_end/basic_run_spec.rb'
 
 # Offense count: 1
@@ -163,10 +162,9 @@ RSpec/InstanceVariable:
   Exclude:
     - 'spec/alexandria/export_library_spec.rb'
 
-# Offense count: 4
+# Offense count: 3
 RSpec/MultipleDescribes:
   Exclude:
-    - 'spec/alexandria/ui/dialogs_spec.rb'
     - 'spec/alexandria/ui/main_app_spec.rb'
     - 'spec/alexandria/ui/ui_utilities_spec.rb'
     - 'spec/alexandria/utilities_spec.rb'
@@ -196,7 +194,7 @@ Style/ClassAndModuleChildren:
     - 'lib/alexandria/ui/icons.rb'
     - 'lib/alexandria/ui/import_dialog.rb'
     - 'lib/alexandria/ui/init.rb'
-    - 'lib/alexandria/ui/preferences_dialog.rb'
+    - 'lib/alexandria/ui/provider_preferences_base_dialog.rb'
 
 # Offense count: 17
 Style/ClassVars:
@@ -219,32 +217,26 @@ Style/CommentedKeyword:
     - 'lib/alexandria/ui/new_book_dialog.rb'
     - 'util/rake/fileinstall.rb'
 
-# Offense count: 112
+# Offense count: 115
 Style/Documentation:
   Enabled: false
 
-# Offense count: 65
+# Offense count: 1
+Style/DoubleNegation:
+  Exclude:
+    - 'lib/alexandria/ui/listview.rb'
+
+# Offense count: 10
 # Configuration parameters: EnforcedStyle.
 # SupportedStyles: annotated, template, unannotated
 Style/FormatStringToken:
   Exclude:
-    - 'lib/alexandria/book_providers.rb'
     - 'lib/alexandria/ui/acquire_dialog.rb'
-    - 'lib/alexandria/ui/book_properties_dialog_base.rb'
-    - 'lib/alexandria/ui/callbacks.rb'
     - 'lib/alexandria/ui/dndable.rb'
-    - 'lib/alexandria/ui/export_dialog.rb'
-    - 'lib/alexandria/ui/keep_bad_isbn_dialog.rb'
     - 'lib/alexandria/ui/listview.rb'
-    - 'lib/alexandria/ui/misc_dialogs.rb'
     - 'lib/alexandria/ui/new_book_dialog.rb'
-    - 'lib/alexandria/ui/new_book_dialog_manual.rb'
-    - 'lib/alexandria/ui/preferences_dialog.rb'
-    - 'lib/alexandria/ui/sidepane_manager.rb'
-    - 'lib/alexandria/ui/smart_library_properties_dialog.rb'
-    - 'lib/alexandria/ui/ui_manager.rb'
 
-# Offense count: 34
+# Offense count: 36
 # Configuration parameters: MinBodyLength.
 Style/GuardClause:
   Enabled: false