-
Notifications
You must be signed in to change notification settings - Fork 100
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
.c shouldn't scrape DuckDuckGo HTML #161
Comments
A side effect of attempting to scrape HTML before using the API: if BeautifulSoup isn't installed, it borks completely, where it could potentially get a result. |
@auscompgeek this is explicitly mentioned in the readme: https://github.com/myano/jenni |
@kaneda Yes, but it causes an exception, so it doesn't even attempt to get a result from the DDG API or from Wolfram|Alpha. |
The "HTML" is scraped first before the API, because a) many times the "HTML" pages has a simpler answer and b) sometimes it is faster. I believe there was another reason of why I originally did it that way, but I can't remember any other reasons as of now. |
Personally, I really wish the google results for .c were more reliable in jenni. They seem/work more reliably when done in a browser. |
The DuckDuckGo API returns calculations perfectly fine...
Moreover, why is it scraping HTML before trying the API?
The text was updated successfully, but these errors were encountered: