diff --git a/boards/bbpress.php b/boards/bbpress.php index 8fc9de3..56cbcdf 100644 --- a/boards/bbpress.php +++ b/boards/bbpress.php @@ -97,7 +97,7 @@ class BBPRESS_Converter extends Converter * @param string $gids A serialized list of original roles * @return string group id(s) */ - function get_group_id($gids) + function get_group_id($gids, $remove=array()) { // bbPress saves roles as ["name" => true] $roles = array_keys(unserialize($gids)); diff --git a/boards/fluxbb/users.php b/boards/fluxbb/users.php index 0506b21..6b8c894 100644 --- a/boards/fluxbb/users.php +++ b/boards/fluxbb/users.php @@ -57,7 +57,7 @@ function convert_data($data) $insert_data['timezone'] = str_replace(array('.0', '.00'), array('', ''), $data['timezone']); $insert_data['lastpost'] = (int)$data['last_post']; - $insert_data['icq'] = $data['icq']; + //$insert_data['icq'] = $data['icq']; $insert_data['hideemail'] = $data['email_setting']; $insert_data['allownotices'] = $data['notify_with_post']; $insert_data['regip'] = my_inet_pton($data['registration_ip']); diff --git a/boards/ipb3/polls.php b/boards/ipb3/polls.php index 633d8f7..7c81e39 100644 --- a/boards/ipb3/polls.php +++ b/boards/ipb3/polls.php @@ -44,7 +44,7 @@ function convert_data($data) $insert_data['import_tid'] = $data['tid']; $insert_data['import_pid'] = $data['pid']; $insert_data['tid'] = $this->get_import->tid($data['tid']); - $choices = unserialize(utf8_decode($data['choices'])); + $choices = unserialize(mb_convert_encoding($data['choices'], 'ISO-8859-1', 'UTF-8')); $choices = $choices[1]; $seperator = ''; diff --git a/boards/ipb3/users.php b/boards/ipb3/users.php index 5d08869..2a53d38 100644 --- a/boards/ipb3/users.php +++ b/boards/ipb3/users.php @@ -67,7 +67,7 @@ function convert_data($data) { $insert_data['birthday'] = $data['bday_day'].'-'.$data['bday_month'].'-'.$data['bday_year']; } - $insert_data['icq'] = $data['field_4']; + //$insert_data['icq'] = $data['field_4']; $insert_data['skype'] = $data['field_10']; $insert_data['timezone'] = str_replace(array('.0', '.00'), array('', ''), $data['time_offset']); $insert_data['timezone'] = ((!strstr($insert_data['timezone'], '+') && !strstr($insert_data['timezone'], '-')) ? '+'.$insert_data['timezone'] : $insert_data['timezone']); diff --git a/boards/mybb.php b/boards/mybb.php index eee6e0d..44b704b 100644 --- a/boards/mybb.php +++ b/boards/mybb.php @@ -92,7 +92,7 @@ class MYBB_Converter extends Converter var $column_length_to_check = array( 'users' => array( 'users' => array( - 'icq' => 'icq' + //'icq' => 'icq' ) ) ); diff --git a/boards/phpbb3/threads.php b/boards/phpbb3/threads.php index 81dc980..bc13a6a 100644 --- a/boards/phpbb3/threads.php +++ b/boards/phpbb3/threads.php @@ -87,7 +87,7 @@ function get_poll_pid($tid) $results = $this->old_db->fetch_field($query, "poll_option_id"); $this->old_db->free_result($query); - $this->get_poll_pid_cache[$tid] = $results; + $this->get_poll_pid_cache[$tid] = (int)$results; return $results; } diff --git a/boards/phpbb3/users.php b/boards/phpbb3/users.php index e9bbd00..b4653ba 100644 --- a/boards/phpbb3/users.php +++ b/boards/phpbb3/users.php @@ -71,7 +71,7 @@ function convert_data($data) $insert_data['regdate'] = $data['user_regdate']; $insert_data['lastactive'] = $data['user_lastvisit']; $insert_data['lastvisit'] = $data['user_lastvisit']; - $insert_data['website'] = $data['user_website']; + $insert_data['website'] = $data['user_website'] ?? ''; $insert_data['lastpost'] = $data['user_lastpost_time']; $birthday = ''; @@ -96,7 +96,7 @@ function convert_data($data) } $insert_data['birthday'] = $birthday; - $insert_data['icq'] = $data['user_icq']; + //$insert_data['icq'] = $data['user_icq'] ?? ''; $insert_data['hideemail'] = $data['user_allow_viewemail']; $insert_data['invisible'] = int_to_01($data['user_allow_viewonline']); $insert_data['allownotices'] = $data['user_notify']; @@ -125,7 +125,7 @@ function convert_data($data) // phpBB 3.1 $insert_data['timezone'] = get_timezone($data['user_timezone']); } - $insert_data['dst'] = $data['user_dst']; + $insert_data['dst'] = $data['user_dst'] ?? 0; $insert_data['signature'] = encode_to_utf8($this->bbcode_parser->convert($data['user_sig'], $data['user_sig_bbcode_uid']), "users", "users"); $insert_data['regip'] = my_inet_pton($data['user_ip']); $insert_data['lastip'] = my_inet_pton($data['user_ip']); diff --git a/boards/punbb/users.php b/boards/punbb/users.php index cad1873..93b6cb5 100644 --- a/boards/punbb/users.php +++ b/boards/punbb/users.php @@ -76,7 +76,7 @@ function convert_data($data) $insert_data['timezone'] = str_replace(array('.0', '.00'), array('', ''), $data['timezone']); $insert_data['lastpost'] = $data['last_post']; - $insert_data['icq'] = $data['icq']; + //$insert_data['icq'] = $data['icq']; $insert_data['hideemail'] = $data['email_setting']; $insert_data['allownotices'] = $data['notify_with_post']; $insert_data['regip'] = my_inet_pton($data['registration_ip']); diff --git a/boards/smf/users.php b/boards/smf/users.php index a4b87cf..7653b40 100644 --- a/boards/smf/users.php +++ b/boards/smf/users.php @@ -70,7 +70,7 @@ function convert_data($data) { $insert_data['birthday'] = date("j-n-Y", strtotime($data['birthdate'])); } - $insert_data['icq'] = $data['ICQ']; + //$insert_data['icq'] = $data['ICQ']; $insert_data['hideemail'] = $data['hideEmail']; $insert_data['invisible'] = int_to_01($data['showOnline']); $insert_data['pmnotify'] = $data['pm_email_notify']; diff --git a/boards/smf2/users.php b/boards/smf2/users.php index 59891bc..9a393d7 100644 --- a/boards/smf2/users.php +++ b/boards/smf2/users.php @@ -70,7 +70,7 @@ function convert_data($data) { $insert_data['birthday'] = date("j-n-Y", strtotime($data['birthdate'])); } - $insert_data['icq'] = $data['icq']; + //$insert_data['icq'] = $data['icq']; $insert_data['hideemail'] = $data['hide_email']; $insert_data['invisible'] = int_to_01($data['show_online']); $insert_data['pmnotify'] = $data['pm_email_notify']; diff --git a/boards/vbulletin3.php b/boards/vbulletin3.php index 0a1cc16..bf320f5 100644 --- a/boards/vbulletin3.php +++ b/boards/vbulletin3.php @@ -115,7 +115,7 @@ class VBULLETIN3_Converter extends Converter ), 'user' => array( 'users' => array( - 'icq' => 'icq' + //'icq' => 'icq' ) ) ); diff --git a/boards/vbulletin3/privatemessages.php b/boards/vbulletin3/privatemessages.php index fad704c..ff897f6 100644 --- a/boards/vbulletin3/privatemessages.php +++ b/boards/vbulletin3/privatemessages.php @@ -60,8 +60,10 @@ function convert_data($data) // However afterwards we need to properly encode all elements again, otherwise we'd get other issues again if(!is_array($touserarray)) { - $touserarray = unserialize(utf8_decode($data['touserarray'])); - array_walk_recursive($touserarray, create_function('&$value, $key', '$value = utf8_encode($value);')); + $touserarray = unserialize(mb_convert_encoding($data['touserarray'], 'ISO-8859-1', 'UTF-8')); + array_walk_recursive($touserarray, function (&$value, &$key) { + $value = mb_convert_encoding($value, 'UTF-8', 'ISO-8859-1'); + }); } // This is the original check in vB diff --git a/boards/vbulletin3/users.php b/boards/vbulletin3/users.php index 969811e..405fded 100644 --- a/boards/vbulletin3/users.php +++ b/boards/vbulletin3/users.php @@ -88,7 +88,7 @@ function convert_data($data) { $insert_data['birthday'] = $data['birthday']; } - $insert_data['icq'] = $data['icq']; + //$insert_data['icq'] = $data['icq']; $insert_data['timezone'] = str_replace(array('.0', '.00'), array('', ''), $insert_data['timezone']); $insert_data['style'] = 0; $insert_data['referrer'] = $data['referrerid']; diff --git a/boards/vbulletin4.php b/boards/vbulletin4.php index 4d8329e..614ab04 100644 --- a/boards/vbulletin4.php +++ b/boards/vbulletin4.php @@ -103,7 +103,7 @@ class VBULLETIN4_Converter extends Converter ), 'user' => array( 'users' => array( - 'icq' => 'icq' + //'icq' => 'icq' ) ) ); diff --git a/boards/vbulletin4/moderators.php b/boards/vbulletin4/moderators.php index 38920c1..38f4d65 100644 --- a/boards/vbulletin4/moderators.php +++ b/boards/vbulletin4/moderators.php @@ -25,7 +25,20 @@ function import() { global $import_session; - $query = $this->old_db->simple_select("moderator", "*", "forumid != '-1'", array('limit_start' => $this->trackers['start_mods'], 'limit' => $import_session['mods_per_screen'])); + $query_options = array(); + + if(isset($this->trackers['start_mods'])) + { + $query_options['limit_start'] = $this->trackers['start_mods']; + } + + if(isset($import_session['mods_per_screen'])) + { + $query_options['limit'] = $import_session['mods_per_screen']; + } + + $query = $this->old_db->simple_select("moderator", "*", "forumid != '-1'", $query_options); + while($moderator = $this->old_db->fetch_array($query)) { $this->insert($moderator); diff --git a/boards/vbulletin4/polls.php b/boards/vbulletin4/polls.php index b60a367..98b0b8c 100644 --- a/boards/vbulletin4/polls.php +++ b/boards/vbulletin4/polls.php @@ -34,7 +34,8 @@ function import() // Restore connections $thread = $this->get_import_tid_poll($poll['pollid']); - $db->update_query("threads", array('poll' => $pid), "import_tid = '".$thread['import_tid']."'"); + + $db->update_query("threads", array('poll' => $pid), "import_tid = '".(isset($thread['import_tid']) ? $thread['import_tid'] : 0)."'"); } } @@ -47,8 +48,8 @@ function convert_data($data) $votes = @explode('|||', $data['votes']); $insert_data['import_pid'] = $data['pollid']; - $insert_data['import_tid'] = $thread['import_tid']; - $insert_data['tid'] = $thread['tid']; + $insert_data['import_tid'] = isset($thread['import_tid']) ? $thread['import_tid'] : 0; + $insert_data['tid'] = isset($thread['tid']) ? $thread['tid'] : 0; $insert_data['question'] = $data['question']; $insert_data['dateline'] = $data['dateline']; $insert_data['options'] = str_replace('|||', '||~|~||', $data['options']); @@ -76,7 +77,7 @@ function get_import_tid_poll($import_pid) $db->free_result($query); } - return $this->cache_tid_polls[$import_pid]; + return isset($this->cache_tid_polls[$import_pid]) ? $this->cache_tid_polls[$import_pid] : 0; } function fetch_total() diff --git a/boards/vbulletin4/posts.php b/boards/vbulletin4/posts.php index 01a35dd..a5643b2 100644 Binary files a/boards/vbulletin4/posts.php and b/boards/vbulletin4/posts.php differ diff --git a/boards/vbulletin4/privatemessages.php b/boards/vbulletin4/privatemessages.php index c48e90b..cd22a55 100644 --- a/boards/vbulletin4/privatemessages.php +++ b/boards/vbulletin4/privatemessages.php @@ -60,8 +60,16 @@ function convert_data($data) // However afterwards we need to properly encode all elements again, otherwise we'd get other issues again if(!is_array($touserarray)) { - $touserarray = unserialize(utf8_decode($data['touserarray'])); - array_walk_recursive($touserarray, create_function('&$value, $key', '$value = utf8_encode($value);')); + $touserarray = unserialize(mb_convert_encoding($data['touserarray'], 'ISO-8859-1', 'UTF-8')); + + if(!is_array($touserarray)) + { + $touserarray = array(); + } + + array_walk_recursive($touserarray, function (&$value, $key) { + $value = mb_convert_encoding($value, 'UTF-8', 'ISO-8859-1'); + }); } // This is the original check in vB @@ -95,7 +103,7 @@ function convert_data($data) // Inserting a pm for one of the recipients so the toid is our id $insert_data['toid'] = $insert_data['uid']; } - elseif(count($recipients['to']) == 1) + elseif(isset($recipients['to']) && count($recipients['to']) == 1) { // Inserting a pm for the sender with only one recipient so we can set the toid $insert_data['toid'] = $recipients['to'][0]; diff --git a/boards/vbulletin4/settings.php b/boards/vbulletin4/settings.php index 3e3c41e..e582403 100644 --- a/boards/vbulletin4/settings.php +++ b/boards/vbulletin4/settings.php @@ -135,7 +135,7 @@ function import() if($setting['varname'] == "moderatenewmembers") { - if($setting['config_value'] == 1) + if(isset($setting['config_value']) && $setting['config_value'] == 1) { $value = "admin"; } diff --git a/boards/vbulletin4/users.php b/boards/vbulletin4/users.php index c10dc59..afb8e68 100644 --- a/boards/vbulletin4/users.php +++ b/boards/vbulletin4/users.php @@ -71,9 +71,9 @@ function convert_data($data) list($bmonth, $bday, $byear) = explode("-", $data['birthday']); $insert_data['birthday'] = $bday."-".$bmonth."-".$byear; } - $insert_data['icq'] = $data['icq']; + //$insert_data['icq'] = $data['icq']; $insert_data['skype'] = $data['skype']; - $insert_data['timezone'] = str_replace(array('.0', '.00'), array('', ''), $insert_data['timezone']); + $insert_data['timezone'] = isset($insert_data['timezone']) ? str_replace(array('.0', '.00'), array('', ''), $insert_data['timezone']) : ''; $insert_data['style'] = 0; $insert_data['referrer'] = $data['referrerid']; $insert_data['regip'] = my_inet_pton($data['ipaddress']); diff --git a/boards/vbulletin5.php b/boards/vbulletin5.php index 927c018..2b1d751 100644 --- a/boards/vbulletin5.php +++ b/boards/vbulletin5.php @@ -103,7 +103,7 @@ class VBULLETIN5_Converter extends Converter ), 'user' => array( 'users' => array( - 'icq' => 'icq' + //'icq' => 'icq' ) ) ); diff --git a/boards/vbulletin5/privatemessages.php b/boards/vbulletin5/privatemessages.php index 6757aa5..5a22ddb 100644 --- a/boards/vbulletin5/privatemessages.php +++ b/boards/vbulletin5/privatemessages.php @@ -60,8 +60,10 @@ function convert_data($data) // However afterwards we need to properly encode all elements again, otherwise we'd get other issues again if(!is_array($touserarray)) { - $touserarray = unserialize(utf8_decode($data['touserarray'])); - array_walk_recursive($touserarray, create_function('&$value, $key', '$value = utf8_encode($value);')); + $touserarray = unserialize(mb_convert_encoding($data['touserarray'], 'ISO-8859-1', 'UTF-8')); + array_walk_recursive($touserarray, function (&$value, &$key) { + $value = mb_convert_encoding($value, 'UTF-8', 'ISO-8859-1'); + }); } // This is the original check in vB diff --git a/boards/vbulletin5/users.php b/boards/vbulletin5/users.php index c562afe..077be33 100644 --- a/boards/vbulletin5/users.php +++ b/boards/vbulletin5/users.php @@ -71,7 +71,7 @@ function convert_data($data) list($bmonth, $bday, $byear) = explode("-", $data['birthday']); $insert_data['birthday'] = $bday."-".$bmonth."-".$byear; } - $insert_data['icq'] = $data['icq']; + //$insert_data['icq'] = $data['icq']; $insert_data['skype'] = $data['skype']; $insert_data['timezone'] = str_replace(array('.0', '.00'), array('', ''), $insert_data['timezoneoffset']); $insert_data['style'] = 0; diff --git a/boards/wbb3.php b/boards/wbb3.php index d2ec81a..a4e459d 100644 --- a/boards/wbb3.php +++ b/boards/wbb3.php @@ -151,7 +151,7 @@ function db_extra()
".$lang->sprintf($lang->database_details, $this->plain_bbname)."
"; - if($import_session['old_db_engine']) + if(!empty($import_session['old_db_engine'])) { $mybb->input['dbengine'] = $import_session['old_db_engine']; } @@ -314,16 +314,16 @@ function db_configuration() $mybb->input['dbengine'] = $mybb->config['database']['type']; } - if($import_session['old_db_host']) + if(!empty($import_session['old_db_host'])) { - $mybb->input['config'][$mybb->input['dbengine']]['dbhost'] = $import_session['old_db_host']; + $mybb->input['config'][$mybb->get_input('dbengine')]['dbhost'] = $import_session['old_db_host']; } else { - $mybb->input['config'][$mybb->input['dbengine']]['dbhost'] = 'localhost'; + $mybb->input['config'][$mybb->get_input('dbengine')]['dbhost'] = 'localhost'; } - if($import_session['old_tbl_prefix']) + if(!empty($import_session['old_tbl_prefix'])) { $tableprefix = $import_session['old_tbl_prefix']; } @@ -331,32 +331,34 @@ function db_configuration() { $tableprefix = $this->prefix_suggestion; } + // This looks probably odd, but we want that the table prefix is shown everywhere correctly foreach($this->supported_databases as $dbs) { $mybb->input['config'][$dbs]['tableprefix'] = $tableprefix; } + // Handling mysqli, mysql_pdo and pgsql_pdo separately. $mybb->input['config']["mysqli"]['tableprefix'] = $tableprefix; $mybb->input['config']["mysql_pdo"]['tableprefix'] = $tableprefix; $mybb->input['config']["pgsql_pdo"]['tableprefix'] = $tableprefix; - if($import_session['old_db_user']) + if(!empty($import_session['old_db_user'])) { - $mybb->input['config'][$mybb->input['dbengine']]['dbuser'] = $import_session['old_db_user']; + $mybb->input['config'][$mybb->get_input('dbengine')]['dbuser'] = $import_session['old_db_user']; } else { - $mybb->input['config'][$mybb->input['dbengine']]['dbuser'] = ''; + $mybb->input['config'][$mybb->get_input('dbengine')]['dbuser'] = ''; } - if($import_session['old_db_name']) + if(!empty($import_session['old_db_name'])) { - $mybb->input['config'][$mybb->input['dbengine']]['dbname'] = $import_session['old_db_name']; + $mybb->input['config'][$mybb->get_input('dbengine')]['dbname'] = $import_session['old_db_name']; } else { - $mybb->input['config'][$mybb->input['dbengine']]['dbname'] = ''; + $mybb->input['config'][$mybb->get_input('dbengine')]['dbname'] = ''; } } @@ -506,10 +508,12 @@ function check_if_done() $module_name = str_replace(array("import_", ".", ".."), "", $import_session['module']); - $this->debug->log->datatrace("total_{$module_name}, start_{$module_name}", array($import_session['total_'.$module_name], $this->trackers['start_'.$module_name])); + $start_module = isset($this->trackers['start_'.$module_name]) ? $this->trackers['start_'.$module_name] : 0; + + $this->debug->log->datatrace("total_{$module_name}, start_{$module_name}", array($import_session['total_'.$module_name], $start_module)); // If there are more work to do, continue, or else, move onto next module - if($import_session['total_'.$module_name] - $this->trackers['start_'.$module_name] <= 0 || $import_session['total_'.$module_name] == 0) + if($import_session['total_'.$module_name] - $start_module <= 0 || $import_session['total_'.$module_name] == 0) { $import_session['disabled'][] = 'import_'.$module_name; $import_session['flash_message'] = $lang->sprintf($lang->import_successfully, $this->settings['friendly_name']); diff --git a/resources/class_converter_module.php b/resources/class_converter_module.php index 9602040..ba552dc 100644 --- a/resources/class_converter_module.php +++ b/resources/class_converter_module.php @@ -412,8 +412,8 @@ public function prepare_insert_array($values, $table='') { $this->board->set_column_warning_in_progress( 'entry', $table, $key, - $lang->sprintf($lang->warning_prepare_data_mismatched_column, $import_session['module'], TABLE_PREFIX.$table, $key, $column['def_type'], 'STRING'), - $lang->sprintf($lang->warning_prepare_data_mismatched_column, $import_session['module'], TABLE_PREFIX.$table, $key, $column['def_type'], 'STRING') + $lang->sprintf($lang->warning_prepare_data_mismatched_column, $import_session['module'], TABLE_PREFIX.$table, $key, $column['def_type'] ?? '', 'STRING'), + $lang->sprintf($lang->warning_prepare_data_mismatched_column, $import_session['module'], TABLE_PREFIX.$table, $key, $column['def_type'] ?? '', 'STRING') ); } diff --git a/resources/class_debug.php b/resources/class_debug.php index ec75fb4..b2e874f 100644 --- a/resources/class_debug.php +++ b/resources/class_debug.php @@ -276,9 +276,21 @@ function generate_plain_backtrace($shift=1) foreach($trace as $call) { - if(!$call['file']) $call['file'] = "[PHP]"; - if(!$call['line']) $call['line'] = " "; - if($call['class']) $call['function'] = $call['class'].$call['type'].$call['function']; + if(empty($call['file'])) + { + $call['file'] = "[PHP]"; + } + + if(empty($call['line'])) + { + $call['line'] = " "; + } + + if(isset($call['class'])) + { + $call['function'] = $call['class'].$call['type'].$call['function']; + } + $call['file'] = str_replace(substr(MYBB_ROOT, 0, -1), "", $call['file']); $backtrace .= "File: {$call['file']} Line: {$call['line']} Function: {$call['function']} -> \r\n"; } diff --git a/resources/class_error.php b/resources/class_error.php index bf9d0d5..43329c0 100644 --- a/resources/class_error.php +++ b/resources/class_error.php @@ -46,15 +46,24 @@ function error($type, $message, $file=null, $line=0, $allow_output=true) $file = str_replace(MYBB_ROOT, "", $file); + if(is_array($message)) + { + $message_string = "[SQL] [{$message['error_no']}]{$message['error']}{$lang->attmodule_ipadress}
"; $import_session['uploads_test'] = 0; } - if(strpos($mybb->input['uploadspath'], "127.0.0.1") !== false) + if(strpos($mybb->get_input('uploadspath'), "127.0.0.1") !== false) { $this->errors[] = "{$lang->attmodule_ipadress2}
"; $import_session['uploads_test'] = 0; diff --git a/resources/modules/avatars.php b/resources/modules/avatars.php index 088c1ab..bb2f81d 100644 --- a/resources/modules/avatars.php +++ b/resources/modules/avatars.php @@ -148,22 +148,22 @@ public function test_readability() $this->debug->log->trace0("Checking readability of avatars from specified path"); - if($mybb->input['avatarspath']) + if($mybb->get_input('avatarspath')) { - $import_session['avatarspath'] = $mybb->input['avatarspath']; + $import_session['avatarspath'] = $mybb->get_input('avatarspath'); if(!empty($import_session['avatarspath']) && my_substr($import_session['avatarspath'], -1) != '/') { $import_session['avatarspath'] .= '/'; } } - if(strpos($mybb->input['avatarspath'], "localhost") !== false) + if(strpos($mybb->get_input('avatarspath'), "localhost") !== false) { $this->errors[] = "{$lang->attmodule_ipadress}
"; $import_session['uploads_avatars_test'] = 0; } - if(strpos($mybb->input['avatarspath'], "127.0.0.1") !== false) + if(strpos($mybb->get_input('avatarspath'), "127.0.0.1") !== false) { $this->errors[] = "{$lang->attmodule_ipadress2}
"; $import_session['uploads_avatars_test'] = 0; diff --git a/resources/modules/users.php b/resources/modules/users.php index cb6b167..251184e 100644 --- a/resources/modules/users.php +++ b/resources/modules/users.php @@ -34,7 +34,7 @@ abstract class Converter_Module_Users extends Converter_Module 'lastvisit' => TIME_NOW, 'lastpost' => 0, 'website' => '', - 'icq' => '', + //'icq' => '', 'skype' => '', 'google' => '', 'birthday' => '', @@ -245,7 +245,9 @@ public function check_for_duplicates(&$user) // Using strtolower and my_strtolower to check, instead of in the query, is exponentially faster // If we used LOWER() function in the query the index wouldn't be used by MySQL - if(strtolower($duplicate_user['username']) == strtolower($username) || my_strtolower($duplicate_user['username']) == strtolower($encoded_username)) + if(is_array($duplicate_user) && ( + strtolower($duplicate_user['username']) == strtolower($username) || my_strtolower($duplicate_user['username']) == strtolower($encoded_username) + )) { if($user[$this->settings['email_column']] == $duplicate_user['email']) { diff --git a/resources/output.php b/resources/output.php index 67e70f4..ef4b929 100644 --- a/resources/output.php +++ b/resources/output.php @@ -84,6 +84,7 @@ class converterOutput var $_progress_bar_constructed = 0; var $_last_left = 0; + private $trackers = array(); /** * Method to print the converter header @@ -280,7 +281,7 @@ function module_list() $this->print_header($lang->module_selection, "", 0); - if($import_session['flash_message']) + if(!empty($import_session['flash_message'])) { echo "{$import_session['flash_message']}