Backfill synonym slugs (DO NOT MERGE) #2785
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #2785 +/- ##
========================================
- Coverage 6.08% 5.88% -0.20%
========================================
Files 171 172 +1
Lines 4340 4365 +25
Branches 476 478 +2
========================================
- Hits 264 257 -7
- Misses 4074 4106 +32
Partials 2 2 ☔ View full report in Codecov by Sentry. |
lpsinger
requested changes
Dec 16, 2024
app/backfill-synonym-slugs.ts
Outdated
Comment on lines
8
to
12
| function* chunks<T>(arr: T[], n: number): Generator<T[], void> { | ||
| for (let i = 0; i < arr.length; i += n) { | ||
| yield arr.slice(i, i + n) | ||
| } | ||
| } |
There was a problem hiding this comment.
You could use lodash's chunk here.
app/backfill-synonym-slugs.ts
Outdated
Comment on lines
16
to
18
| const db = await tables() | ||
| const client = db._doc as unknown as DynamoDBDocument | ||
| const TableName = db.name('synonyms') |
There was a problem hiding this comment.
Architect's service discovery will not work in this context. You'll need to look up the name of the table using Amazon SSM.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
DO NOT MERGE!!! for review only
closes #2784