Describable mixin #170
Closed
Describable mixin #170
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hello, thanks for the PR! What you did is an interface, not a mixin. Also for the commit message can you please reword it? Thanks |
|
I've amended the commit. Whether an interface is fine or it has to be a mixin, is up to you. |
|
The point is to do a mixin, not an interface :P
Le 26 octobre 2021 18:47:23 Max ***@***.***> a écrit :
…
I've amended the commit. Whether an interface is fine or it has to be a
mixin, is up to you.
—
You are receiving this because you commented.
Reply to this email directly, view it on GitHub, or unsubscribe.
Triage notifications on the go with GitHub Mobile for iOS or Android.
|
|
Alright, so, I recommend you search up what a Edit: I searched on Google, and found this, which contains many examples and definitions for mixins: https://stackoverflow.com/questions/533631/what-is-a-mixin-and-why-are-they-useful |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #158
Also, excuse the typo in the commit message.