Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

How to test the sqlite package? #8

Open
maxlorenz opened this issue Mar 15, 2016 · 3 comments
Open

How to test the sqlite package? #8

maxlorenz opened this issue Mar 15, 2016 · 3 comments

Comments

@maxlorenz
Copy link
Member

Find a way to test the sqlite.go file without reimplementing 90% of the importer package (the importer is not sqlite specific). The problem here: the sqlite implementation reads from channels, which must be opened, closed and run concurrently

@jronak
Copy link

jronak commented Mar 16, 2016

On It Max, should be able to have sample osm data in JSON.

@blide
Copy link
Contributor

blide commented Mar 16, 2016

The current implementation of the writer is not really good. It's not even possible to get an entity that produces the error. Maybe it's not too late yet to reimplement writers.
I'm ready to refactor code if you agree with me. I think writer method would receive only one entity and return an error, but it must be thread-safe. That approach would be easier to use and test.

@maxlorenz
Copy link
Member Author

Sure! It's more a POC. As long as you don't pull request non-working code, please suggest a better way

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants