Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

PKCE token request errors not handled and request is not shown. #85

Open
mricherzhagen opened this issue Nov 27, 2023 · 1 comment
Open

Comments

@mricherzhagen
Copy link

There is no error handling for the PKCE token request, and the request that is attempted is also not shown in the UI.

The PKCE token request can fail, for example, if there is no CORS-setting on the server for oauthdebugger.com.

The request should be shown, and the errors should be caught and displayed.

Nevertheless, very useful tool. A little bit surprised it requires a server component, though.

@nbarbettini
Copy link
Owner

There is no error handling for the PKCE token request, and the request that is attempted is also not shown in the UI.

The PKCE token request can fail, for example, if there is no CORS-setting on the server for oauthdebugger.com.

The request should be shown, and the errors should be caught and displayed.

This is a good suggestion, thanks!

A little bit surprised it requires a server component, though.

I tried to eliminate this, but a server is required for handling POST-based redirect flows.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants