Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Praises and a few suggestions #1

Open
kburnik opened this issue Dec 14, 2017 · 0 comments
Open

Praises and a few suggestions #1

kburnik opened this issue Dec 14, 2017 · 0 comments

Comments

@kburnik
Copy link

kburnik commented Dec 14, 2017

Hi, this is great and plenty helpful, exactly what I was looking for!

I'd like to leave you a few suggestions:

  • Consider adding a LICENSE.md file so I can reference you and the license
  • Consider creating a separate library for functions which don't require the server and then reference that project in the server solution (e.g. git submodule), for example, I only need the functions which generate the typos
  • You might want to consider creating a Dockerfile instead of having scripts for separate linux distros

Hope this finds you well, cheers! :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant