Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[sda-download] a missing iss.json file means no visa validation will be done. #1182

Open
4 tasks
jbygdell opened this issue Dec 10, 2024 · 0 comments
Open
4 tasks
Labels
bug Something isn't working Security Bad: Security problem

Comments

@jbygdell
Copy link
Collaborator

jbygdell commented Dec 10, 2024

Describe the bug
If sda-download is started and the iss.json file is missing or is empty or that it is not part of the config for sda-download, no checks if the visa provider is allowed to issue visas against datasets that exists in the archive that sda-download is connected to.

Steps to reproduce
Start sda-download in you desired way with an empty or missing iss.json file, or without the oidc.trusted.iss part of the config file. Get the token and query the metadata endpoint to list datasets.

Expected behavior

  • Without a iss.json file the sda-download should not start.
  • It shouldn't start if the json is empty
  • It shouldn't start if the content of the json cannot be parsed
  • Tests verifying the fix are added

** Extra information**
The line 358 in auth.go should be false:

Additional context

Estimation of size: small/medium/big

Estimation of priority: low/medium/high

@jbygdell jbygdell added the bug Something isn't working label Dec 10, 2024
@viklund viklund added the Security Bad: Security problem label Dec 11, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working Security Bad: Security problem
Projects
None yet
Development

No branches or pull requests

2 participants