Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Non-Convex Faces Not Triangulated Correctly #56

Open
maxattack opened this issue Jun 21, 2020 · 4 comments
Open

Non-Convex Faces Not Triangulated Correctly #56

maxattack opened this issue Jun 21, 2020 · 4 comments

Comments

@maxattack
Copy link

The triangulate() helper function in ofbx.cpp doesn't properly ear-cut non-convex faces, leading to non-internal edges being placed.

image
image
@maxattack
Copy link
Author

maxattack commented Jun 22, 2020 •
edited
Loading

The algorithm is not too tricky -- it's called "ear-cutting." A reference: http://www-cgrl.cs.mcgill.ca/~godfried/teaching/cg-projects/97/Ian/algorithm1.html

Implementation was only ~200LOC

image

@nem0
Copy link
Owner

nem0 commented Jun 22, 2020

Hi, I'm not sure when will I get to this, but if you need this soon you can disable ofbx triangulation and and do correct triangulation on your side.

@maxattack
Copy link
Author

Yeah, that's what I've already implemented. Just putting it on your radar :)

@maxattack
Copy link
Author

For the curious: https://github.com/maxattack/Trinket/blob/master/Source/Triangulate.cpp

@mafiesto4 mafiesto4 mentioned this issue Oct 14, 2023
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@nem0 @maxattack