Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Correct numerics of gif_cond_* neurons #1565

Open
heplesser opened this issue Apr 29, 2020 · 6 comments
Open

Correct numerics of gif_cond_* neurons #1565

heplesser opened this issue Apr 29, 2020 · 6 comments
Assignees
Labels
I: Behavior changes Introduces changes that produce different results for some users S: Normal Handle this with default priority stale Automatic marker for inactivity, please have another look here T: Bug Wrong statements in the code or documentation

Comments

@heplesser
Copy link
Contributor

While analysing #1097, we discovered that the numerics of the gif_cond_ neuron have slight weakness: The spike triggered current is evolved outside the ODE solver, so a constant stc value is applied during all sub-steps of a NEST time step. The stc should be updated inside the rhs function, to have exact values at each substep.

@heplesser heplesser added T: Bug Wrong statements in the code or documentation S: Normal Handle this with default priority I: Behavior changes Introduces changes that produce different results for some users labels Apr 29, 2020
@clinssen
Copy link
Contributor

For more details, see #1582

@github-actions
Copy link

github-actions bot commented Sep 3, 2021

Issue automatically marked stale!

@github-actions github-actions bot added the stale Automatic marker for inactivity, please have another look here label Sep 3, 2021
@stinebuu stinebuu modified the milestones: NEST 3.2, NEST 3.3 Dec 6, 2021
@clinssen clinssen removed this from the NEST 3.3 milestone Mar 7, 2022
@heplesser
Copy link
Contributor Author

@clinssen @pnbabu Ping!

@clinssen
Copy link
Contributor

clinssen commented Dec 1, 2022

Do we prefer the precise analytic solution to be computed inside the GSL solver inner loop? This would provide numerical precision at the expense of some more exp() calls. We can also numerically approximate this decay inside the GSL loop and replace it with precise values at the end of every timestep. In the first case, we will need to dynamically allocate the ODE state vector, as the model supports an arbitrary number of STC and SFA time constants, and these will all have to go into the state vector.

@heplesser
Copy link
Contributor Author

I would argue for precision at the expense of exp() calls.

@github-actions github-actions bot removed the stale Automatic marker for inactivity, please have another look here label Dec 6, 2022
@github-actions
Copy link

github-actions bot commented Feb 5, 2023

Issue automatically marked stale!

@github-actions github-actions bot added the stale Automatic marker for inactivity, please have another look here label Feb 5, 2023
@jessica-mitchell jessica-mitchell moved this to To do in Models Aug 6, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
I: Behavior changes Introduces changes that produce different results for some users S: Normal Handle this with default priority stale Automatic marker for inactivity, please have another look here T: Bug Wrong statements in the code or documentation
Projects
Status: To do
Development

No branches or pull requests

4 participants