Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merge of to_nest() and nest_install() #503

Closed
clinssen opened this issue Jun 25, 2019 · 3 comments · Fixed by #720
Closed

Merge of to_nest() and nest_install() #503

clinssen opened this issue Jun 25, 2019 · 3 comments · Fixed by #720

Comments

@clinssen
Copy link
Contributor

to_nest() requires the user to specify the directory where generated code will be written into. The same directory needs to be specified as a parameter to install_nest(). If these functions are merged, and the user does not particularly care where the model is generated, there should be no need to specify a target path.

The target location should default to a place where NEST can find the generated .so file without additional specification of LD_LIBRARY_PATH. Possibly, nest-config should be interrogated for the requisite path.

@Silmathoron
Copy link
Member

See also #480

@clinssen
Copy link
Contributor Author

clinssen commented Nov 3, 2021

One potential solution could be:

  • rename to_nest(...) to generate_target_code(target="nest", ...)
  • rename install_nest(...) to build_target_code(target="nest", ...)
  • add a new function generate_build_target_code(target="nest", ...) that simply calls the first two in order.

Side points:

  • pynestml/utils/model_installer.py is NEST-specific and should be moved to pynestml/codegeneration (or a subdirectory in there)
  • same for NEST-specific functions in pynestml/frontend/pynestml_frontend.py

@tfardet
Copy link

tfardet commented Nov 4, 2021

Are there plans to make NESTML not NEST specific? Given the name this seems like a strange idea ^^"
If not, then I would rather try to avoid breaking all user codes...
I'd be fine with adding a new function combining both previous functions without renaming them, though

@clinssen clinssen linked a pull request Jan 17, 2022 that will close this issue
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants