Replies: 3 comments
-
Good call @kmk3 ! I'll review these and merge the ones I'm familiar/comfortable with - let's get them all in/any changes needed made! |
Beta Was this translation helpful? Give feedback.
0 replies
-
All merged! Thanks for the feedback, reviews and merges. |
Beta Was this translation helpful? Give feedback.
0 replies
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
-
So there are quite a few pull requests that have been opened for a while.
Most of the following ones are relatively simple and all of them have had no
changes (and no request for changes) for more than two weeks:
This one seems simple enough and has had no changes for over a week:
Thoughts on merging them?
The more commits that are made to master in the meantime, the longer (and
potentially wider) the merge lines are going to be, which makes the git history
harder to read. Merging the existing PRs would help with that on at least
branches that are created/rebased after the merges.
Also, there may be branches in development that relate to or that are blocked
by existing PRs (I have some, though the relevant PR is not in the above
lists).
Lastly, because I think it's helpful when projects are responsive.
Beta Was this translation helpful? Give feedback.
All reactions