Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

slice should be only slice index, but it's display name #86

Open
r03ert0 opened this issue Jan 5, 2025 · 0 comments
Open

slice should be only slice index, but it's display name #86

r03ert0 opened this issue Jan 5, 2025 · 0 comments

Comments

@r03ert0
Copy link
Member

r03ert0 commented Jan 5, 2025

Only the slice index (0 based) should be used for indexing data, and the display name only for display. We have https://microdraw.pasteur.fr/F117_P32_Nissl/F117_P32_Nissl.json&slice=54 (NSA 57) instead of https://microdraw.pasteur.fr/F117_P32_Nissl/F117_P32_Nissl.json&slice=53.

And the DB entries look like:

{
    "fileID" : "https://microdraw.pasteur.fr/F117_P32_Nissl/F117_P32_Nissl.json&slice=54 (NSA 57)",
    "user" : "katjaq",
    "project" : "FIINDv2",
    "Hash" : "-5edfaa41",
    "annotation" : {
        "path" : ["..."],
        "name" : "Region 1",
        "uid" : "9d819dcde390d8"
    },
    "backup" : true
}

We should use slice indices exclusively, and to cleanup the database accordingly (plus, the current method maybe allows for xss attacks!)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

1 participant