Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Breaking Change in PostgreSQL dependency #226

Closed
Pumba98 opened this issue Apr 15, 2022 · 4 comments
Closed

Breaking Change in PostgreSQL dependency #226

Pumba98 opened this issue Apr 15, 2022 · 4 comments

Comments

@Pumba98
Copy link

Pumba98 commented Apr 15, 2022

Hi, you updated the postgresql subchart to version 11. That version has some breaking changes in the values.yaml and also changes the default PostgreSQL Version from 11 to 14.
Please see https://docs.bitnami.com/kubernetes/infrastructure/postgresql/administration/upgrade/
At least the proposed values in your values.yaml need to be adjusted to fit the new chart version.

Greets 😄

Pumba98 added a commit to Pumba98/k3s-flux-cluster that referenced this issue Apr 15, 2022
@Pumba98
Copy link
Author

Pumba98 commented Apr 23, 2022

I think the biggest part of this issue was fixed in #227
There still exists a problem for people who want to upgrade the nextcloud chart because the migration from PostgreSQL 11 to 14 doesn't work without manual work and recreation of the postgresql secret and statefulset is necessary.

@bo0ts
Copy link

bo0ts commented May 2, 2022

An incompatible database upgrade (with a change in persistence no less) is no what I expected to find in a minor version bump and I would have appreciated a warning in the readme or changelogs.

@tvories
Copy link
Collaborator

tvories commented May 2, 2022

Agreed, this should have been a major version bump. It would be nice to get a changelog setup as well as a way for the release info to pull in changes to the release. If someone has an idea on how to add change info to the release action, that would be helpful

@jessebot
Copy link
Collaborator

jessebot commented Jul 26, 2024

If someone has an idea on how to add change info to the release action, that would be helpful

This has been done!

@Pumba98 sorry for the inconvenience on this. 🙇 In #602 we're publishing some new guidelines to ensure we're better about this in the future, and we've also added some new tests to actually test installs with PostgreSQL enabled, so we catch breaking changes in the subchart as well:

# test the helm chart with postgresql subchart enabled

Since we've hopefully set some better guidelines for the future to prevent this issue, and there's not been activity here for a couple of years, I'll get this closed for now.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants