Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

bin dir scripts don't seem to work #59

Closed
matthdsm opened this issue Jul 4, 2024 · 6 comments
Closed

bin dir scripts don't seem to work #59

matthdsm opened this issue Jul 4, 2024 · 6 comments
Labels
bug Something isn't working

Comments

@matthdsm
Copy link
Collaborator

matthdsm commented Jul 4, 2024

VERSION

0.1.1

CMD

nextflow run nf-core/fetchngs -profile test -c nomad.config  -w /scratch --outdir ./fetchngs

Error

ERROR ~ Error executing process > 'NFCORE_FETCHNGS:SRA:SRA_IDS_TO_RUNINFO (SRR14709033)'

Caused by:
  Process `NFCORE_FETCHNGS:SRA:SRA_IDS_TO_RUNINFO (SRR14709033)` terminated with an error exit status (127)


Command executed:

  echo SRR14709033 > id.txt
  sra_ids_to_runinfo.py \
      id.txt \
      SRR14709033.runinfo.tsv \
  
  
  cat <<-END_VERSIONS > versions.yml
  "NFCORE_FETCHNGS:SRA:SRA_IDS_TO_RUNINFO":
      python: $(python --version | sed 's/Python //g')
  END_VERSIONS

Command exit status:
  127

Command output:
  (empty)

Command error:
  .command.sh: line 4: sra_ids_to_runinfo.py: command not found

Work dir:
  /scratch/f2/9a53d5bf94fffd7ad3e4fa6a61d9af

Tip: when you have fixed the problem you can continue the execution adding the option `-resume` to the run command line

 -- Check '.nextflow.log' file for details

CONFIG

plugins {
     id '[email protected]'
}

process {
     executor = "nomad"
     docker.enabled = true
}

nomad {
     client {
          address = "http://nomad.server"
          token   = "token"
     }

     jobs {
          deleteOnCompletion = false
          namespace = "nextflow"
          datacenters = ['dc']

          volumes = [
               { type "csi" name "nf_scratch_volume" path "/scratch"}
          ]
     }
}
@matthdsm
Copy link
Collaborator Author

matthdsm commented Jul 4, 2024

reproducible on the azure server

@matthdsm
Copy link
Collaborator Author

matthdsm commented Jul 4, 2024

Data in assets also isn't available, effectively breaking multiqc in all nf-core pipelines

@matthdsm
Copy link
Collaborator Author

matthdsm commented Jul 4, 2024

I guess we're still missing something like this:
https://github.com/nextflow-io/nextflow/blob/059151a6bad40baedcaaf2b31fa455a951bd420b/plugins/nf-azure/src/main/nextflow/cloud/azure/batch/AzBatchExecutor.groovy#L89-L98

@matthdsm
Copy link
Collaborator Author

matthdsm commented Jul 4, 2024

Setting NXF_ASSETS to a directory mounted by nomad fixes this issue

@abhi18av
Copy link
Member

abhi18av commented Jul 4, 2024

Yeah, this makes it a good candidate (with workDir ) to perhaps dynamically set this at runtime 🤔

That being said, shall we close this issue?

@jagedn jagedn added the bug Something isn't working label Jul 6, 2024
@abhi18av
Copy link
Member

abhi18av commented Jul 8, 2024

Closing this as the best way to test the plugin is through #62 (comment)

And for a released build, the same process should be followed after adding the relevant NXF_* parameters.

@abhi18av abhi18av closed this as completed Jul 8, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

3 participants