Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make GENOME and GENOME_AND_ANNOTATION into workflows #81

Open
FernandoDuarteF opened this issue Nov 5, 2024 · 3 comments
Open

Make GENOME and GENOME_AND_ANNOTATION into workflows #81

FernandoDuarteF opened this issue Nov 5, 2024 · 3 comments
Assignees
Labels
enhancement New feature or request

Comments

@FernandoDuarteF
Copy link
Collaborator

We should make our two main subworflows (GENOME and GENOME_AND_ANNOTATION) into workflows, as it makes more sense for the structure and modularization of the pipeline (we cannot use subworkflows inside subworflows).

For example, as for now, we would not be able to import the BUSCO subworkflow from #77 inside GENOME_AND_ANNOTATION subworkflow.

@FernandoDuarteF FernandoDuarteF added the enhancement New feature or request label Nov 5, 2024
@FernandoDuarteF FernandoDuarteF self-assigned this Nov 5, 2024
@GallVp
Copy link
Member

GallVp commented Nov 5, 2024

Hi @FernandoDuarteF

I like the idea of workflows.

However, I am a bit confused as to why subworkflows can not be imported into other subworkflows?

@FernandoDuarteF
Copy link
Collaborator Author

I now realise that it is possible to import subworkflows into other subworkflows. I should have said that we 'should not' or 'try to avoid', as I assume it's not good practice, but perhaps I'm wrong?

Either way I think in this case we should have two workflows.

@GallVp
Copy link
Member

GallVp commented Nov 5, 2024

I now realise that it is possible to import subworkflows into other subworkflows. I should have said that we 'should not' or 'try to avoid', as I assume it's not good practice, but perhaps I'm wrong?

Either way I think in this case we should have two workflows.

Good point.

I can't think of a reason why sub-workflows within a local pipeline sub-workflow would be a problem.

For reusable sub-workflows, it is certainly a problem because of version slips. When a nested sub-workflow/module is modified, the only deterrent against breaking the dependent sub-workflow is nf-test tags.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants