Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Save the Salmon and RSEM reference index in addition to the STAR index when running with --save_reference #1065

Closed
amizeranschi opened this issue Jul 25, 2023 · 3 comments

Comments

@amizeranschi
Copy link

amizeranschi commented Jul 25, 2023

Description of feature

When running the pipeline with --save_reference, currently only the STAR index is saved. It would be useful to also include the Salmon and RSEM index inside the ./genome/index/ directory.

@amizeranschi amizeranschi changed the title Save the Salmon reference index in addition to the STAR index when running with --save_reference Save the Salmon and RSEM reference index in addition to the STAR index when running with --save_reference Jul 25, 2023
@drpatelh
Copy link
Member

Hi @amizeranschi ! We need a much better solution to deal with reference genomes overall. We have been talking about this for a while and ideally, we write a separate workflow that generates all of the genome assets required by the pipeline.

@drpatelh drpatelh added this to the 3.13 milestone Oct 15, 2023
@kvn95ss
Copy link

kvn95ss commented Oct 25, 2023

I'm trying to run the pipeline on my laptop. I have the RSEM index generated already, but the pipeline fails as I don't have enough ram (It needs 72, I have 64 GB). However, its very frustrating as I do NOT want to use RSEM - I'm running star_salmon so I don't understand why I still need the RSEM index. Saving indexes will really be helpful to run smaller runs locally.

@pinin4fjords
Copy link
Member

@amizeranschi what Harshil says is true. But the pipeline should already be saving e.g. the Salmon index - not just the STAR one.

Note that this would only apply when a Salmon index is generated. This only happens when pseudo_aligner is set an Salmon is run in mapping-based mode, which is not the default behaviour.

RSEM_PREPAREREFERENCE_GENOME will not run unless aligner is set to star_rsem and params.rsem_index is not set.

I believe the issue in the OP might have been due to a misunderstanding about when the Salmon index is generated, and this is not in fact an ongoing issue, so I'm going to close. Please feel free to reopen if I am mistaken.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

4 participants