Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adding "--grouplineages" parameter in the nf-core/viralrecon #405

Closed
bsalehe opened this issue Nov 29, 2023 · 3 comments
Closed

Adding "--grouplineages" parameter in the nf-core/viralrecon #405

bsalehe opened this issue Nov 29, 2023 · 3 comments
Assignees
Milestone

Comments

@bsalehe
Copy link

bsalehe commented Nov 29, 2023

Hi,

I am running the dev version which also supports the analysis of wastewater mixed samples with freyja variants, demix boot modules using samples from PRJNA819090. As the number of samples is much bigger, I am running pipeline on the hpc. All samples run successfully in every process except few which cause the viralrecon to throw errors. One of the errors is "raise error.SolverError(
cvxpy.error.SolverError: Solver 'ECOS' failed. Try another solver, ..." which has been explained in the freyja issue here and has been actually fixed here by adding --grouplineages option in both demix and boot methods which essentially addresses samples with low coverage that causes the error to occur. I wonder if you could add this option in the pipeline as to hopefully avoid throwing this error.

Many thanks

@Joon-Klaps Joon-Klaps self-assigned this Jan 17, 2024
@Joon-Klaps
Copy link

Joon-Klaps commented Jan 17, 2024

Hi,

I'll make a pull request to add a variable to set the --depthcutoff for the module (because if I look a the thread you mentioned they patched it from grouplineages to depthcutoff, let me know if I missed something).
Note, if you ever run into a similar issue, nextflow allows users to add specific arguments to a module with little effort so in the meantime you can replace a part of the modules_illumina.config (or if you used nanopore the modules_nanopore.config) file with the following if the cutoff value of 1:

             withName: 'FREYJA_DEMIX' {
                ext.args = [
                  '--depthcutoff 1',
                ].join(' ').trim()
                publishDir = [
                    path: { "${params.outdir}/variants/freyja/demix" },
                    mode: params.publish_dir_mode,
                    pattern: "*.{tsv,csv}"
                ]
            }
            withName: 'FREYJA_BOOT' {
                ext.args = [
                  '--depthcutoff 1',
                    '--boxplot pdf',
                ].join(' ').trim()
                publishDir = [
                    path: { "${params.outdir}/variants/freyja/bootstrap" },
                    mode: params.publish_dir_mode,
                    pattern: "*.{tsv,csv,pdf}"
                ]
            }

@svarona svarona added this to the 2.7 milestone Jan 25, 2024
@svarona
Copy link
Contributor

svarona commented Jan 25, 2024

Should we consider this issue as solved? @Joon-Klaps

@Joon-Klaps
Copy link

Yep!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants