Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow skipping freyja boot #417

Closed
tavareshugo opened this issue Feb 20, 2024 · 1 comment · Fixed by #426
Closed

Allow skipping freyja boot #417

tavareshugo opened this issue Feb 20, 2024 · 1 comment · Fixed by #426
Assignees
Labels
enhancement Improvement for existing functionality
Milestone

Comments

@tavareshugo
Copy link
Contributor

Description of feature

To save some computation, it may sometimes be desirable to skip freyja's bootstrapping step.

My suggestion would be to allow using --freyja_repeats 0. At the moment, using it like this throws an internal error from freyja.
But maybe viralrecon could interpret 0 (or any negative number, for that matter) as meaning "don't run the bootstrap step".

In fact, it may be worth considering --freyja_repeats 0 as the default, in case those processing clinical isolates forget to do --skip_freyja and end up spending a lot of unnecessary compute time bootstrapping.

I guess an alternative would be to add a new option --skip_freyja_boot.

@tavareshugo tavareshugo added the enhancement Improvement for existing functionality label Feb 20, 2024
@svarona svarona added this to the 2.7 milestone Apr 22, 2024
@Joon-Klaps Joon-Klaps self-assigned this May 2, 2024
@Joon-Klaps
Copy link

Good point.
I'll add a skip_freyja_boot and make sure that repeats are >0

@Joon-Klaps Joon-Klaps linked a pull request May 2, 2024 that will close this issue
9 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement Improvement for existing functionality
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants