-
Notifications
You must be signed in to change notification settings - Fork 58
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
PBP data not available for 2022 #85
Comments
also not seeing data for 2023.... |
Possibly related to your problems, I am seeing a bug with the fastparquet library and numpy versions 2+ related to np.float_ being removed. It was in a fresh installation, python 3.12.4, jupyterlab + nfl_data_py. The final error from nfl data was that the year was not available, but the stack trace showed the actual bug. I added this to my imports to patch the problem:
Got the suggestion from here: Downgrading numpy didn't work. |
Thanks for you post Jon — I came here bc I had this issue. I followed the first recommendation in the StackOverflow post where I uninstalled numpy and then used:
Posting for transparency
|
@JonBraund that is a separate issue. As discussed in #98 (comment), I caution against using nfl_data_py with numpy and pandas 2.0+ as they aren't yet supported and multiple issues stemming from the upgrade have been reported. I would downgrade to the latest 1.X versions for now, and keep an eye out for support via nfl_data_py 1.0 later this year! |
@nateb7722, @roe-men - are you still seeing missing 2022 and 2023 data now? I tried with the same python and package versions you specified, but I haven't been able to reproduce that issue yet. Whether it's related or not, note my comment above regarding avoiding pandas 2.0+ for now. |
using np.float_ = np.float64 worked for me, haven't had this issue since |
@nateb7722 I published a new version of the package last night. You can install it with the command below, and then you shouldn't need the
If you encounter that issue again with the new version, let me know and I'll re-open your ticket. |
Thank you, the change you made helped downgrade the dependencies in my environment properly. It seems to have resolved some other strange behaviour. |
I haven't had this problem before but for some reason I am getting the response "data not available for 2022" from import_pbp function. Running on macOS, python 3.10.13, pandas version 2.2.1
The text was updated successfully, but these errors were encountered: