Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Data Clarity - /Players v. /Players_Components #63

Open
2 tasks done
vitolytics opened this issue Nov 27, 2024 · 1 comment
Open
2 tasks done

Data Clarity - /Players v. /Players_Components #63

vitolytics opened this issue Nov 27, 2024 · 1 comment

Comments

@vitolytics
Copy link

Is there an existing issue for this?

  • I have searched the existing issues

Have you installed the latest development version of the package(s) in question?

  • I have installed the latest development version of the package.

If this is a data issue, have you tried clearing your nflverse cache?

I have cleared my nflverse cache and the issue persists.

What version of the package do you have?

n/a

Describe the bug

Variance in /players_components/players (csv, parquet, et. al) and /players/players (csv, parquet, et. all).

In releases, I am noticing players_components is updated most recently, and included additional id fields. However, 'players' is last updated over a month ago, but is labeled "this will be what is used going forward".

The 'players' file in Players Components has ~17600 records, whereas the file in /Players has ~20700 records but limited id fields.

Reprex

n/a

Expected Behavior

Please clarify 'correct' source of truth.

nflverse_sitrep

n/a

Screenshots

n/a

Additional context

n/a

@mrcaseb
Copy link
Member

mrcaseb commented Nov 27, 2024

The players file that is currently located in players_components will be our future players file. The future source of truth. Since its format is slightly different than the current players data we did not officially announce it or replace the old players file. This will happen next offseason.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants