Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Core] Use CLAY_PACKED_ENUM for all enum types #179

Open
Zettexe opened this issue Jan 10, 2025 · 3 comments · May be fixed by #185
Open

[Core] Use CLAY_PACKED_ENUM for all enum types #179

Zettexe opened this issue Jan 10, 2025 · 3 comments · May be fixed by #185
Labels
enhancement New feature or request

Comments

@Zettexe
Copy link
Contributor

Zettexe commented Jan 10, 2025

Currently some enum types such as Clay_TextElementConfigWrapMode and Clay_PointerCaptureMode are defined using enum instead of CLAY_PACKED_ENUM. I spent like 2 days trying to figure out why text wrapping wasn't working since I assumed all enum types were of type uint8_t.
@nicbarker
Copy link
Owner

@Zettexe Sorry you had to deal with that! I think it's a good call, trying to make all the enums a consistent size (at least within one platform). Btw great work on the zig bindings, the ergonomics are looking amazing!

@nicbarker nicbarker added the enhancement New feature or request label Jan 10, 2025
@nicbarker nicbarker changed the title Use CLAY_PACKED_ENUM for all enum types [Core] Use CLAY_PACKED_ENUM for all enum types Jan 10, 2025
@Zettexe
Copy link
Contributor Author

Zettexe commented Jan 10, 2025 •
edited
Loading

Sorry you had to deal with that!

No worries, if anything it gave me some much needed debugger practice.

Btw great work on the zig bindings, the ergonomics are looking amazing!

Thank you for the kind words.

@sayedMurtadha sayedMurtadha linked a pull request Jan 11, 2025 that will close this issue
Open
@sayedMurtadha
Copy link

@nicbarker I opened a pull request for this issue since it is a very low effort and does not require too many changes, if that is okay, thanks

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Change Enums to CLAY_PACKED_ENUM sayedMurtadha/clay
3 participants
@nicbarker @sayedMurtadha @Zettexe