-
Notifications
You must be signed in to change notification settings - Fork 369
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Why are binaries being distributed in the repository? #243
Comments
Hello, there are a couple of reasons we include binaries in the repo 🙂
I'm not sure I agree from the perspective of distributing malicious code - any code that you clone from someone's repository and run on your host machine carries that risk, unless you exhaustively review every line of code yourself (including the dependencies)
That's actually not the intention here - Clay itself is just a single file. The examples are provided for educational purposes and have CMakeLists files associated with them to make them easier to build for people who use CMake, but the actual library itself doesn't rely on CMake at all. If you're after a direct link to just the latest main It's also worth mentioning that there are now CMake options to disable pulling the code from the examples if you're concerned about size: |
My mistake, I assumed you were planning some distribution in view of the latest changes to the build script. Plenty of "single file libraries" are distributed so that they can integrate with build systems like CMake or meson, but from what I understand that was not your objective. Malicious code is much easier to detect compared to malicious binaries, I don't really see how this is arguable. Still, I now get how you are using the repository and which priorities are in place. I cannot say I like this approach to be honest, but my question was answered :D. |
The odin bindings in this repository are distributing a very high number of binaries. This is bad on multiple levels:
If binaries really must be distributed, it would be better to split them in their own repository, so that it only affects their users.
Incidently, I would also suggest cutting down on the number of fonts distributed. All examples could just use one or two instead of having one copy each. File links can be used in git repositories.
The text was updated successfully, but these errors were encountered: