-
Notifications
You must be signed in to change notification settings - Fork 1.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Added export functionality to pivotUI #187
Conversation
Works well but it repeats the first dimension column twice.. in your PR, it repeats the COLOR column in both A,B Columns in excel |
Thanks for this! I'm getting married soon so I won't have a ton of time to look at this until September, but I just wanted to let you know I'm grateful and I'm not ignoring you :) |
Thanks again for the contribution, but commit f636484 is my preferred way of implementing exporting: via an optional Renderer component which directly accesses the underlying |
@nicolaskruchten : not really sure this is the best place for the bug report, but I noticed two strange issues:
|
@LaurensRietveld thanks for the feedback!
I'm very open to suggestions as to alternative ways of doing this, though! |
Sorry about the delay! I think there is no -proper- way of doing this, and what table layout to use mostly depends on a persons taste. I have two main requirements:
So for (1) I'd opt for including the row-headers instead of concatenating these with the cell values. And for (2), I'd simply duplicate a row span value into the corresponding cells. But again, this is just my personal preference, and I'm not claiming this to be -the- best approach ;) ps. Something more related to the UI part of this issue: if you share my preference for requirement (1), then it might be better to make this agnostic to the underlying data object, and generate the exported csv on the actual html table. This would make it easier to keep the CSV as consistent as possible with the regular table renderer(s). |
Hello Nicolas,
Thought I might contribute to this fantastic library of yours. Added an optional field to pivoutUI in which the user can export the table.
I had to normalize the table before being able to do this, as it got quite difficult due to the rowspan/colspans involved.
Feel free to merge, if you so desired