Skip to content
This repository has been archived by the owner on Jan 18, 2021. It is now read-only.

Max Brightness #28

Open
gjbianco opened this issue Jul 10, 2019 · 0 comments · May be fixed by #29
Open

Max Brightness #28

gjbianco opened this issue Jul 10, 2019 · 0 comments · May be fixed by #29

Comments

@gjbianco
Copy link

gjbianco commented Jul 10, 2019 •
edited
Loading

Currently, trying to send a brightness of 255 just causes the command to be ignored. It seems like it is known that 254 is the actual max:

#19 (comment)

Either the documentation should be updated to reflect this or, better yet, clamp the brightness value being passed in. e.g. sending a brightness > 254 causes 254 to be used.

I should be able to open a PR for this hopefully sometime this week, if that would be helpful.

Edit: looks like the docs were changed last year but the change was never released?
@gjbianco gjbianco changed the title Max Brightness Incorrect in Documentation Max Brightness Jul 10, 2019
@gjbianco gjbianco linked a pull request Jul 10, 2019 that will close this issue
Open
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Clamp brightness to max gjbianco/node-red-contrib-tradfri
1 participant
@gjbianco