Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

App review #1

Open
nidhi1608 opened this issue Mar 26, 2014 · 3 comments
Open

App review #1

nidhi1608 opened this issue Mar 26, 2014 · 3 comments

Comments

@nidhi1608
Copy link
Owner

/cc @nesquena

The app is feature complete, please review. I have tried to incorporate all the required as well as optional user stories. Features, screenshots and time spent can be found in the attached README file.

Additional features:

  1. Progress bar when the grid and images are loading.
  2. User can swipe left or right in the image display view to go to the next or previous image - used viewpager control.

It seems like github caches images in the README file, so they may not have uniform size when you review the app. Hopefully it will be refreshed by the time you review this app. Also, this was my first time updating a README file and its far from perfect. So, your feedback and guidance will be much appreciated.

Thanks,
Nidhi

@nesquena
Copy link

👍 excellent work Nidhi! Very impressed with this submission. A few notes after checking out the code:

  • You should start organizing your code into subfolders for better organization
  • Properly reused the single base method to fetch results for both initial load and the pagination
  • Manual handling of image loading, creating square images, etc looks great.
  • Great organization of the results into it's own object
  • Great job using a dialog fragment for filters!
  • Properly used spinners (with populated values) to allow users to select filters
  • Good to see you used a filters object to represent the filters to apply to the query
  • Nice job adding the share intent to the image detail view!

Also, here's a more detailed Project 2 Feedback Guide here which covers the most common issues with this submitted project. Read through the feedback guide point-by-point to determine how you could improve your submission.

Let us know if you have any other thoughts or questions about this assignment. The next assignment (Twitter Client) will be especially important since it introduces the majority of the remaining pieces necessary to build a fully functional API client with complex feeds of data and user creation.

@nesquena
Copy link

Just a note but based on your submissions in the class so far, you have consistently put in a great effort. Assuming you enjoy the course at the end of the 8 weeks, would be great to have you help out in the future as a mentor or even have you teach as an instructor if that's something that interests you. Let's chat more at end of the bootcamp.

Do you have prior experience with Android development before taking this class?

@nidhi1608
Copy link
Owner Author

Thanks Nathan. I would love to help in any way I can.

No, I don't have prior experience building Android applications. I was watching the video tutorials from the Android development course on Coursera and had reached as far as week 4 if that counts.
However, I do have experience building ASP.NET applications and apart from a few new concepts related to views and UI in general, developing for Android devices is not fundamentally different from the usual OOP in my opinion. Also, the video walkthroughs per assignment, cliffnotes, the official android developer's guide and stackoverflow have been really really useful.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants