Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add more settings #9

Open
nightsha-de opened this issue Mar 10, 2021 · 2 comments
Open

Add more settings #9

nightsha-de opened this issue Mar 10, 2021 · 2 comments

Comments

@nightsha-de
Copy link
Owner

nightsha-de commented Mar 10, 2021

Add the ability to set autoUnlockPlugWhenCharged, maxChargeCurrentAC, climatisationWithoutExternalPower, climatizatioAtUnlock and windowHeatingEnabled options (as available in the WeConnectId app).

@pixxelfriend
Copy link
Contributor

I guess it would be nicer to pass the options via constructor directly, like the developers from the io broker plugin did. Its easier to use and it would reduce the amount code a bit, because the setter methods will not be needed anymore. If you like, i can create another pull request.

@nightsha-de
Copy link
Owner Author

I agree for the basic mandatory parameters (e.g. username, password, car type). For everything else we'll need the setter methods anyway or you won't be able to set a different target SOC or target temperature for example without instantiating a new object of the class. But feel free to create a pull request with your proposal and we discuss it there.

This issue was intended as a reminder for me to add the ability to set autoUnlockPlugWhenCharged, maxChargeCurrentAC, climatisationWithoutExternalPower, climatizatioAtUnlock and windowHeatingEnabled options (as available in the WeConnectId app). Unfortunately I'm a bit occupied with work and offline projects lately so bear with me if responses take a little longer sometimes.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants