Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

API should handle caching of results or not require caching #11

Closed
ACharbonneau opened this issue Nov 6, 2020 · 3 comments
Closed

API should handle caching of results or not require caching #11

ACharbonneau opened this issue Nov 6, 2020 · 3 comments
Assignees
Labels
enhancement New feature or request Epic 2 Issue to complete for Epic 2 release

Comments

@ACharbonneau
Copy link
Contributor

No description provided.

@jonathancrabtree
Copy link
Contributor

Can this issue be moved or closed? It appears to be a dashboard-api issue, not a dashboard issue. In addition, since deriva-py implements client-side caching by default I believe that by extension dashboard-api should do the same.

@jrchudy
Copy link
Contributor

jrchudy commented Feb 12, 2021

@jonathancrabtree it looks like we changed the dashboard pages to use the dashboard APIs instead of the cached JSON documents. If this issue is intended to be for dashboard-api as you suggested, we can move it.

If these changes have already been made in the dashboard-api repo, then we can just close this instead of moving it.

@jrchudy jrchudy added enhancement New feature or request Epic 2 Issue to complete for Epic 2 release labels Feb 12, 2021
@jonathancrabtree
Copy link
Contributor

The API handles result caching thanks to the built-in caching provided by the deriva-py layer. There is the separate question of whether it's sufficient, particularly for initial requests involving non-public catalogs, but I think that's probably covered by nih-cfde/dashboard-api#13 and so I'm closing this case.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request Epic 2 Issue to complete for Epic 2 release
Projects
None yet
Development

No branches or pull requests

3 participants