Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Find a home for the Javascript and CSS files #22

Open
RLC-DCPPC opened this issue May 24, 2022 · 4 comments
Open

Find a home for the Javascript and CSS files #22

RLC-DCPPC opened this issue May 24, 2022 · 4 comments
Assignees

Comments

@RLC-DCPPC
Copy link

RLC-DCPPC commented May 24, 2022

Put in existing static folder and establish tag and release process and incorporate using npm

@RLC-DCPPC
Copy link
Author

Why can I not add Mike D'Arcy or Karl C to this issue?

@jonathancrabtree
Copy link
Collaborator

Here are a couple of examples showing how the viewers (one for the Gene page and one for the Anatomy page) are currently referenced:

https://mii.podvis.org/cfde-ge1/gene.html
https://mii.podvis.org/cfde-ge1/anatomy.html

There are multiple viewers but only a single set of JavaScript and CSS files that need to be packaged up and released. I'll have to look into whether it's possible to compile/package these in such a way that we don't have to use the "anatomy?numTopGenes=25" style for passing parameters (I think this was mentioned as a potential problem for hosting this as static S3 content.)

@karlcz
Copy link
Collaborator

karlcz commented May 31, 2022

The source of those pages actually uses #/anatomy?... which puts it all in the URL fragment (to the right of #) so this is all good. Those are interpreted by the browser/page and not sent to the server when requesting the HTML sources.

@mikedarcy
Copy link
Collaborator

I was able to get this deployed to the dev server, but it required some changes in how the VUE app was built in production mode, due to the fact that we need this app to function when deployed to a sub-path off of the web root and therefore needed some configuration for finding code and assets at relative URL paths. I've submitted these changes as PR #23.

You can see the app functioning on dev with the following URLs, similar to the ones referenced above:

https://app-dev.nih-cfde.org/gexb/#/gene_tissues?gencode_id=ENSG00000000003&width=1200&height=450&numTopTissues=10&tissueSiteDetailIds=Liver,Lung

https://app-dev.nih-cfde.org/gexb/#/anatomy?uberon_ids=UBERON%3A0002369,UBERON%3A0002037&width=1400&height=550&numTopGenes=25

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants