-
Notifications
You must be signed in to change notification settings - Fork 19
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Try to find issues with the app and propose a solution. #2
Comments
Hello @niharika2810 , I think there is a typo mistake in the issue description. |
Hey Thanks, correcting it. |
Hello, @niharika2810 the footer(or header) Progress bar from the paginated data is keep on loading even though the network call is completed and the error message is displayed. we can fix this by showing the progress bar only when the state is loading in the LoadStateViewHolder like this .
instead of This is Fixed |
Hello, @niharika2810 there is no retry option or any button to retry if the data is empty or if it's the first time the user has opened and without an internet connection so the user won't get any data from the DB or from the network so I think there has to be a retry option or some kind of message. for this we can add a loadstatelistener for the adapter in the both fragments and check the data and we can show the empty layout like this. adapter.addLoadStateListener { This is Fixed |
The app is built in Kotlin with the architectural pattern, dependency injection and Navigation component integrated.
Run the app -> try to find issues -> Write down the steps to reproduce -> Propose a solution for the issue
The text was updated successfully, but these errors were encountered: