Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Refactor day bar chart #1

Open
2 tasks
ninest opened this issue Jan 27, 2023 · 0 comments
Open
2 tasks

Refactor day bar chart #1

ninest opened this issue Jan 27, 2023 · 0 comments
Assignees
@ninest

Comments

@ninest
Copy link
Owner

ninest commented Jan 27, 2023 •
edited
Loading

The bar chart consists of two client components, DayBarChart and DayBarChartInner.

DayBarChart uses useMeasure to determine the size of the div while DayBarChartInner is the actual chart. The prop today refers to the current day (Mon/Tue) the chart is showing data for. If today happens to be what day it is, then there is a bar with a the live percentage. This bar is not grey. today should be changed to something like currentDayHour

To do:

  • change today to something like currentDayHour
  • don't assume that the last record is the live data, instead, find it using the records list or take it as a prop
@ninest ninest self-assigned this Jan 27, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@ninest ninest

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@ninest