Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

servert assets does not include files without extension #2993

Closed
danielroe opened this issue Jan 13, 2025 · 1 comment · Fixed by #2995
Closed

servert assets does not include files without extension #2993

danielroe opened this issue Jan 13, 2025 · 1 comment · Fixed by #2995
Labels
pending triage

Comments

@danielroe
Copy link
Member

Environment

Nitro v2.10.4

Reproduction

danielroe/nitro-reproductions#2

Describe the bug

bundledStorage does snapshot storage, but this storage does not persist into the server and is not accessible once built.

Additional context

No response

Logs

No response
@pi0 pi0 changed the title bundledStorage no longer seems to add bundled storage to built bundledStorage does not include files without extension Jan 13, 2025
@pi0 pi0 changed the title bundledStorage does not include files without extension servert assets does not include files without extension Jan 13, 2025
@pi0 pi0 mentioned this issue Jan 13, 2025
Merged
@pi0
Copy link
Member

pi0 commented Jan 13, 2025

Thanks for repro. Nitro server-assets and bundled assets always included only keys with extensions. (#2995 enable for all)

In your example, if you use locales:general:en.json it works.

@pi0 pi0 closed this as completed in #2995 Jan 13, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
pending triage
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

fix(server-assets): include files without ext by default nitrojs/nitro
2 participants
@pi0 @danielroe