Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Mismatches between config.json exported by export_paged_llm_v1.py and expected by shortfin #405

Closed
renxida opened this issue Nov 1, 2024 · 2 comments
Assignees
Labels
enhancement New feature or request

Comments

@renxida
Copy link
Contributor

renxida commented Nov 1, 2024

The following edits were required to make llama3 8b fp16 work:

config["attn_head_count"] = 8 # 8 instead of 32
config["paged_kv_cache"] = {}
config["paged_kv_cache"]["block_seq_stride"] = config["block_seq_stride"]
del config["block_seq_stride"]
config["paged_kv_cache"]["device_block_count"] = 256

There are 2 main problems:

  • the attn_head_count should be set to attention_head_count_kv from export_paged_llm_v1 and not attention_head_count. This should be fixed in sharktank, at least by including both attention head counts
  • kvcache params should be in config["paged_kv_cache"]

Really need integration tests between sharktank and shortfin.

@renxida
Copy link
Contributor Author

renxida commented Nov 1, 2024

This was triaged in #401

@renxida
Copy link
Contributor Author

renxida commented Feb 5, 2025

Fixed by #487

@renxida renxida closed this as completed Feb 5, 2025
@renxida renxida self-assigned this Feb 5, 2025
@renxida renxida added the enhancement New feature or request label Feb 5, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant