Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Error in the code #18

Open
agoodge opened this issue Sep 27, 2023 · 2 comments
Open

Error in the code #18

agoodge opened this issue Sep 27, 2023 · 2 comments

Comments

@agoodge
Copy link

agoodge commented Sep 27, 2023

Hi,
Lines 841-846 in multiple_features.py reads:

        self.xyz_mean = torch.mean(self.patch_xyz_lib)
        self.xyz_std = torch.std(self.patch_rgb_lib)
        self.rgb_mean = torch.mean(self.patch_xyz_lib)
        self.rgb_std = torch.std(self.patch_rgb_lib)
        self.fusion_mean = torch.mean(self.patch_xyz_lib)
        self.fusion_std = torch.std(self.patch_rgb_lib)

Is this correct? It looks like an error.

Thanks

@leefty-1024
Copy link

leefty-1024 commented Oct 4, 2023

I have same question. But the result is bad if I fix it

@nomewang
Copy link
Owner

This code mainly does scaling on the values of the data, because there is some instability in the image edge values of the XYZ data, so we use a uniform scaling factor and mean value. Maintaining the way the code is written works better.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants