Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ProducerSettings should default to acks=All #173

Open
felixkrull-neuland opened this issue Jan 16, 2024 · 2 comments
Open

ProducerSettings should default to acks=All #173

felixkrull-neuland opened this issue Jan 16, 2024 · 2 comments

Comments

@felixkrull-neuland
Copy link

Kafka's producer defaults to acks=all (docs) but this library's ProducerSettings defaults to acks=1. In my opinion, this is an unexpected change in behaviour from Kafka's defaults which is not what I expect from a wrapper library.

Also, according to the Kafka docs, the Acks.MinusOne variant is unnecessary because it's equivalent to all.

@nomisRev
Copy link
Owner

Hey @felixkrull-neuland,

IMO it makes sense to default to the same default as Kafka. I'm going to add this in the next release, if you're interested in contributing this I'd be happy to accept and merge the PR ☺️

@kfh
Copy link

kfh commented Feb 7, 2025

@nomisRev Isn't this solved by #189 ? 🤔

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants