From 5e71305f447b0c5c5798bd6e485c34089ee6a373 Mon Sep 17 00:00:00 2001 From: nadav mizrahi Date: Sun, 11 Aug 2024 14:28:18 +0300 Subject: [PATCH] NSFS | versioning | don't show .versions folder on list-object-versions Signed-off-by: nadav mizrahi --- src/sdk/namespace_fs.js | 4 ++-- src/test/unit_tests/test_bucketspace_versioning.js | 7 +++++++ 2 files changed, 9 insertions(+), 2 deletions(-) diff --git a/src/sdk/namespace_fs.js b/src/sdk/namespace_fs.js index f55d612b6f..e58e939a46 100644 --- a/src/sdk/namespace_fs.js +++ b/src/sdk/namespace_fs.js @@ -718,8 +718,8 @@ class NamespaceFS { if ((!ent.name.startsWith(prefix_ent) || ent.name < marker_curr || ent.name === this.get_bucket_tmpdir_name() || - ent.name === config.NSFS_FOLDER_OBJECT_NAME) && - !this._is_hidden_version_path(ent.name)) { + ent.name === config.NSFS_FOLDER_OBJECT_NAME) || + this._is_hidden_version_path(ent.name)) { return; } const isDir = await is_directory_or_symlink_to_directory(ent, fs_context, path.join(dir_path, ent.name)); diff --git a/src/test/unit_tests/test_bucketspace_versioning.js b/src/test/unit_tests/test_bucketspace_versioning.js index cc70dc27db..e38eecf819 100644 --- a/src/test/unit_tests/test_bucketspace_versioning.js +++ b/src/test/unit_tests/test_bucketspace_versioning.js @@ -3053,6 +3053,13 @@ mocha.describe('List-objects', function() { } }); }); + + mocha.it('list object versions - should not list .versions folder', async function() { + const res = await s3_client.listObjectVersions({Bucket: bucket_name, Delimiter: "/"}); + res.CommonPrefixes?.forEach(obj => { + assert.notEqual(obj.Prefix, ".versions/"); + }); + }); }); async function create_object(object_path, data, version_id, return_fd) {