Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

enable golint #26

Open
dbarrosop opened this issue Jun 9, 2019 · 1 comment
Open

enable golint #26

dbarrosop opened this issue Jun 9, 2019 · 1 comment

Comments

@dbarrosop
Copy link
Contributor

enabling golint with with golangci-lint requires some extra handling, we need to enable it and fix the issues raised by it. To enable it, make lint should be:

.PHONY: lint
lint:
	docker run \
		--rm \
		-v $(PWD):/go/src/$(PROJECT) \
		-w /go/src/$(PROJECT) \
		golangci/golangci-lint \
			golangci-lint run
	docker run \
		--rm \
		-v $(PWD):/go/src/$(PROJECT) \
		-w /go/src/$(PROJECT) \
		golangci/golangci-lint \
			golangci-lint run --no-config --exclude-use-default=false --disable-all --enable=golint

@nleiva
Copy link
Collaborator

nleiva commented Jun 10, 2019

I didn't know GolangCI-Lint. I would normally just go with go fmt, so need to learn more about this option before commenting.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants