-
Notifications
You must be signed in to change notification settings - Fork 1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
🐛 IiifPrint does not split or create relationships #343
Comments
Currently blocked by samvera/hyku#2177 |
TODO: LaRita may have a branch to merge, that also updates iiif print to these changes. cc @laritakr i343-iiif-print-valkyrization |
Blocked: Waiting to be updated in hyku |
QA RESULTS: BLOCKEDPals knapsack importer is not working. I first uploaded a csv that were missing headers and the errors did not get reported. Sample CSV (missing headers) - i347-qa-error.zip perhaps #status_info needs to be updated to #set_status_info def valid_import?
missing_fields_by_model = records.each_with_object({}) do |record, hash|
record.compact!
record.transform_keys!(&:downcase).transform_keys!(&:to_sym)
missing_fields = missing_fields_for(record)
hash[record[:model]] = missing_fields if missing_fields.present?
end
raise_error_for_missing_fields(missing_fields_by_model) if missing_fields_by_model.keys.present?
file_paths.is_a?(Array)
rescue StandardError => e
importer.set_status_info(e)
false
end After that, I corrected the headers and imported, but get a NoMethodError: #find is returning false Sample CSV: |
QA RESULTS: PASS ✅Tested on HYKU STAGING I manually imported a multi page pdf. Set the feature flag to use UV instead of PDF.js. It correctly split the PDF: |
IiifPrint is not splitting appropriately. The purpose of this ticket is to handle PDFs appropriately.
Ref #341
Acceptance Criteria
On a properly configured tenant & work,
The text was updated successfully, but these errors were encountered: