From e7515bd1be7f97879b2fe70a805d530d46652d57 Mon Sep 17 00:00:00 2001
From: "Jason J." <iam@ovrhere.com>
Date: Tue, 4 Nov 2014 17:18:47 -0400
Subject: [PATCH] Moved listview, added padding to listview, fixed colouring
 issue

[Ref]: Moved the listview into its own file for easier maintaince
[Fix][Mod]: Added vertical padding to bottom of listview & fixed
flashing listview issue in 2.3.3
---
 ..._check_off_disabled_focused_holo_light.png | Bin 0 -> 263 bytes
 res/layout-w720dp/fragment_main.xml           |   5 +--
 res/layout-xlarge/fragment_main.xml           |   5 +--
 res/layout/fragment_main.xml                  |  11 +++---
 res/layout/viewstub_currency_listview.xml     |  32 ++++++++++++++++++
 res/values/colors.xml                         |   7 ++--
 6 files changed, 48 insertions(+), 12 deletions(-)
 create mode 100755 res/drawable-hdpi/appbasetheme_light_btn_check_off_disabled_focused_holo_light.png
 create mode 100755 res/layout/viewstub_currency_listview.xml

diff --git a/res/drawable-hdpi/appbasetheme_light_btn_check_off_disabled_focused_holo_light.png b/res/drawable-hdpi/appbasetheme_light_btn_check_off_disabled_focused_holo_light.png
new file mode 100755
index 0000000000000000000000000000000000000000..e979e1f48e257a2f8d56632d7a346010f1815087
GIT binary patch
literal 263
zcmeAS@N?(olHy`uVBq!ia0vp^1|ZDA1|-9oezpUtbDl1aAsP4H&M@RU<RIW0+#(Rv
zRl%`w_PN!POpJ-1GY_3QXI-K4{$bDVsZ)=>d3CD#!|gwNVmY3e^D;0TU_bHqV%9IG
z%)Rmd7R)rwUKnxx-sdOkXG1q<I6c!@nO(HAvt(&@)d#<G+k5Be-PYNd9_{{S)46-W
z3VXO*`XYr@o#Ys;mqw&0H5Wg67~#&?c<`^bxT=5y10xGE@!&eE*58%uYr<BR-S~BF
zi^cBVJ!V_7jx{}g_rmPmzPm2r2~qFwJTGNn_z^viljZTo+$Xt$K%X&qy85}Sb4q9e
E00pFPasU7T

literal 0
HcmV?d00001

diff --git a/res/layout-w720dp/fragment_main.xml b/res/layout-w720dp/fragment_main.xml
index 322296f..090588f 100755
--- a/res/layout-w720dp/fragment_main.xml
+++ b/res/layout-w720dp/fragment_main.xml
@@ -32,10 +32,11 @@
     		android:layout_marginRight="@dimen/activity_horizontal_margin"
             />
         
-        <ListView  android:id="@+id/currConv_main_listView"
+        <include  android:id="@+id/currConv_main_listView"
             android:layout_width="wrap_content"
     		android:layout_height="wrap_content" 
     		android:layout_weight="1.0"
-    		android:cacheColorHint="@color/currconv_listFade" 
+    		
+    		layout="@layout/viewstub_currency_listview"
     		/>    
 </LinearLayout>
diff --git a/res/layout-xlarge/fragment_main.xml b/res/layout-xlarge/fragment_main.xml
index 322296f..090588f 100755
--- a/res/layout-xlarge/fragment_main.xml
+++ b/res/layout-xlarge/fragment_main.xml
@@ -32,10 +32,11 @@
     		android:layout_marginRight="@dimen/activity_horizontal_margin"
             />
         
-        <ListView  android:id="@+id/currConv_main_listView"
+        <include  android:id="@+id/currConv_main_listView"
             android:layout_width="wrap_content"
     		android:layout_height="wrap_content" 
     		android:layout_weight="1.0"
-    		android:cacheColorHint="@color/currconv_listFade" 
+    		
+    		layout="@layout/viewstub_currency_listview"
     		/>    
 </LinearLayout>
diff --git a/res/layout/fragment_main.xml b/res/layout/fragment_main.xml
index 7971411..ad42448 100755
--- a/res/layout/fragment_main.xml
+++ b/res/layout/fragment_main.xml
@@ -28,10 +28,11 @@
 		    android:layout_marginLeft="@dimen/activity_horizontal_margin"
 		    android:layout_marginRight="@dimen/activity_horizontal_margin" 
             />
-        
-        <ListView  android:id="@+id/currConv_main_listView"
-            android:layout_width="match_parent"
+                
+        <include  android:id="@+id/currConv_main_listView"
+            android:layout_width="wrap_content"
     		android:layout_height="wrap_content" 
-    		android:layout_marginTop="@dimen/currConv_main_listView_topPadding"
-    		android:cacheColorHint="@color/currconv_listFade" />    
+    		
+    		layout="@layout/viewstub_currency_listview"
+    		/>    
 </LinearLayout>
diff --git a/res/layout/viewstub_currency_listview.xml b/res/layout/viewstub_currency_listview.xml
new file mode 100755
index 0000000..a70dc7c
--- /dev/null
+++ b/res/layout/viewstub_currency_listview.xml
@@ -0,0 +1,32 @@
+<?xml version="1.0" encoding="utf-8"?>
+<!--
+   Copyright 2014 Jason J.
+
+   Licensed under the Apache License, Version 2.0 (the "License");
+   you may not use this file except in compliance with the License.
+   You may obtain a copy of the License at
+
+       http://www.apache.org/licenses/LICENSE-2.0
+
+   Unless required by applicable law or agreed to in writing, software
+   distributed under the License is distributed on an "AS IS" BASIS,
+   WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+   See the License for the specific language governing permissions and
+   limitations under the License.
+-->
+<!-- "footerDividersEnabled" + "clipToPadding" allows for better padding
+    of the last element. The fadingEdge needs to be removed because
+    a) it is not "used" as expected because b) it overlaps the bottom elements
+    (likely due to  "clipToPadding" being false) -->
+<ListView  xmlns:android="http://schemas.android.com/apk/res/android"
+            android:layout_width="match_parent"
+    		android:layout_height="wrap_content" 
+    		android:layout_marginTop="@dimen/currConv_main_listView_topPadding"
+    		
+    		android:footerDividersEnabled="false"
+	        android:clipToPadding="false"
+	        android:fadingEdge="none"
+	        android:paddingBottom="@dimen/activity_vertical_margin"   
+	        
+	        android:cacheColorHint="@android:color/transparent"
+    		 /> 
\ No newline at end of file
diff --git a/res/values/colors.xml b/res/values/colors.xml
index 9652355..e546c0e 100755
--- a/res/values/colors.xml
+++ b/res/values/colors.xml
@@ -17,14 +17,15 @@
 <resources>
     <!-- The approximation of black for this project.  -->
    <color name="currConv_black">#080808</color>
+   <!-- The dark grey for this project -->
+   <color name="currConv_darkgrey">#888888</color>
    
    <!-- Background color -->
    <color name="currconv_background">#e8f6f7</color>
    <!-- Action bar color -->
    <!-- <color name="currConv_actionBar">#BAE6EA</color>  -->
    <color name="currconv_actionBar">#333</color>  
-   <!-- List fade  color -->
-   <color name="currconv_listFade">@color/currconv_background</color>
+   
    
    <!-- The colour used for warnings. -->
    <color name="currconv_warningColor">#aa1111</color>
@@ -34,5 +35,5 @@
    <color name="currconv_outputEven">#99c6f1f4</color>
    <!-- Currency output list colours: The colour for odd rows. 
    Starting in first row. Transparent-->
-   <color name="currconv_outputOdd">#0fff</color>
+   <color name="currconv_outputOdd">@android:color/transparent</color>
 </resources>