Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Cache Devicons Node:highlighted_name|icon #2984

Open
alex-courtis opened this issue Nov 3, 2024 · 0 comments
Open

Cache Devicons Node:highlighted_name|icon #2984

alex-courtis opened this issue Nov 3, 2024 · 0 comments
Labels
performance performance enhancement

Comments

@alex-courtis
Copy link
Member

Devicons HighlightedString for name and icon will not change unless:

  • options change
  • name changes
  1. Cache these in the Node (preferred)
  2. add a cache around get_icon (will grow large, avoid)

1 could be achieved by overloading .name.
It doesn't appear that name is set anywhere, hence safe to calculate once during construction.
Explorer will be destroyed on options change, clearing cached values.

@alex-courtis alex-courtis added the performance performance enhancement label Nov 3, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
performance performance enhancement
Projects
None yet
Development

No branches or pull requests

1 participant