From aab5ba09d5d43ac6bf8875cec9ee89d3c291ac32 Mon Sep 17 00:00:00 2001 From: EhsanK Date: Wed, 8 Mar 2017 15:25:20 -0500 Subject: [PATCH] Hotfix: hasText value is incorrectly set Following the refactoring in CL: 2694543002 the value of hasText is incorrectly set. To be precise, hasText is always set to the negate of its correct value. BUG=602427 Review-Url: https://codereview.chromium.org/2735633005 Cr-Commit-Position: refs/heads/master@{#454901} (cherry picked from commit 6e3e9e553fee7cd6246ac4bd604303e5cdb3694f) Review-Url: https://codereview.chromium.org/2741503002 . Cr-Commit-Position: refs/branch-heads/3029@{#66} Cr-Branched-From: 939b32ee5ba05c396eef3fd992822fcca9a2e262-refs/heads/master@{#454471} --- content/browser/renderer_host/render_widget_host_view_mac.mm | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/content/browser/renderer_host/render_widget_host_view_mac.mm b/content/browser/renderer_host/render_widget_host_view_mac.mm index d60da64073eb..b7b6e741b555 100644 --- a/content/browser/renderer_host/render_widget_host_view_mac.mm +++ b/content/browser/renderer_host/render_widget_host_view_mac.mm @@ -3422,7 +3422,7 @@ - (id)validRequestorForSendType:(NSString*)sendType BOOL returnTypeIsString = [returnType isEqual:NSStringPboardType]; const content::TextInputManager::TextSelection* selection = renderWidgetHostView_->GetTextSelection(); - BOOL hasText = !selection || selection->selected_text().empty(); + BOOL hasText = selection && !selection->selected_text().empty(); BOOL takesText = renderWidgetHostView_->GetTextInputType() != ui::TEXT_INPUT_TYPE_NONE;