Window doesn't close with close event handler and window.close()

[sysrage]

NWJS Version : 0.58.0
Operating System : Windows 10

Expected behavior

When a window uses window.close(), handling of the close event should behave the same as if nw.Window.get().close() was called or the user manually closed the window.

Actual behavior

If window.close() is used to close a window, an event handler cannot be attached to the close event. If an event is attached, the window does not actually close when win.close(true) is called.

How to reproduce

1. Open NW.js SDK and open the DevTools console.
2. Execute:

nw.Window.get().on('close', function() {
  this.close(true);
});

3. Execute:

window.close();

4. Note that the window does not close. However, the user can no longer interact with the window.

[TheJaredWilcurt]

Tested locally and could reproduce in NW.js 0.58.0-SDK on Win 10 64:

• window.close() - Closes dev tools, ends UI interactivity, but the window and UI is still visible.
• nw.Window.get().close() - closes the window and dev tools. All processes end.
• nw.App.quit() - Closes the window and dev tools. All processes end.
• process.exit(0) - Closes dev tools. UI removed but window stays open.
• process.exit(1) - Closes dev tools. UI replaced with "Aw, Snap! RESULT_CODE_KILLED" Chromium error page.

Min Repro:

• nw7808.zip

[TheJaredWilcurt]

EDIT: Updated this, I put "0.50.0" as verified good when it should be verified bad.

Verified bug is not present in:

• 0.40.0

Verified bug is present in:

• 0.45.0
• 0.50.0
• 0.50.1
• 0.50.2
• 0.50.3
• 0.51.0
• 0.52.0
• 0.53.0
• 0.55.0
• 0.58.0

Diff:

• nw-v0.40.0...nw-v0.50.0

@rogerwang

[ev8dev]

Yesterday I was struggling with process.exit() as well after updating my NW.js version. I need to quit my application with a 0 or 1 as exit code to capture this with a second application while closing all NW.js related processes.

[rogerwang]

Thanks for the sample and testing. but the bug is in 0.50.0 as well

[TheJaredWilcurt]

nw7808.zip

Version	win.close()	nw.App.quit()	window.close()	process.exit(0)	process.exit(1)
0.42.0	✔️	✔️	✔️	✔️	✔️
0.42.1	✔️	✔️	✔️	✔️	✔️
0.42.2	✔️	✔️	✔️	✔️	✔️
0.42.3	✔️	✔️	✔️	✔️	✔️
0.42.4	✔️	✔️	✔️	❌	❌
0.45.0	✔️	✔️	✔️	❌	❌
0.46.0	✔️	✔️	✔️	❌	❌
0.46.1	✔️	✔️	✔️	❌	❌
0.46.2	✔️	✔️	✔️	❌	❌
0.46.3	✔️	✔️	❌	❌	❌
0.58.0	✔️	✔️	❌	❌	❌

• nw-v0.42.3...nw-v0.42.4
• nw-v0.46.2...nw-v0.46.3

@rogerwang Updated table with tested versions and relevant diffs

[ssnangua]

An interim solution, Works for me :)

chrome.tabs.onRemoved.addListener(() => {
    nw.Window.getAll((list) => {
        list.forEach((win) => {
            if (win.cWindow.tabs.length === 0) {
                win.close(true);
            }
        });
    });
});