You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Disabling nw2 in 0.68.0 and newer versions makes "x" button in the window (on all OSs) not trigger close events equivalent to that of the "Close" option in the menu
#8000
Closed
2 of 3 tasks
pd-l2ork opened this issue
Nov 8, 2022
· 2 comments
Before opening an issue, please search and see if it has already been raised.
Bug Report
Feature Request
Successfully reproduced against the latest version of NW.js?
Please use our mailing list or Gitter chatroom to ask questions. The issue tracker is only for bugs and feature requests, in English only. Please note that issues without a repro or code snippet are less likely to be resolved.
Current/Missing Behavior
Up until 0.67.1 with nw2 disabled when closing a window by clicking on the "x" button on the window bar would trigger the same close events as pressing CMD/CTRL+W or clicking on Close option inside the File menu. On 0.68.0 and newer this is not the case anymore. This is not the problem with nw2. Only when nw2 is disabled.
Expected/Proposed Behavior
Closing the window using the "x" button in the window bar should trigger the same close events.
Additional Info
It should be simple to reproduce. Just create a close event that should be triggered when closing the windo w and notice how it is not being triggered when closing the window using the "x" button located on the window's top bar.
Given the major slowdown with the use of the nw2 and scripting (see #7 the fix for this is a must since the slowdown makes nw2 currently not comparable/usable when compared to nw1).
Also, I just realized that this is a duplicate of #7981, so I am closing this one.
Operating System: All (Linux, OSX, Windows).
NW.js Version: 0.68.0 - 0.70.1 (0.67.1 and earlier works fine)
Repro Link:
Code snippet:
Crash report: N/A
The text was updated successfully, but these errors were encountered:
OK, so I did a bit more digging. It appears that after 0.67.1 (0.68.0 and onwards) clicking on the "x" to close window does not trigger the same close actions as pressing CMD/CTRL+W (or selecting "Close" option from the File menu). This appears to be the issue, so mechanisms that should be invoked when pressing window close simply aren't. Hence, everything is stuck inside pd-l2ork. Pressing CMD/CTRL+W does invoke those mechanisms and therefore things work just fine. This is only when nw2 is disabled (when it is enabled, it works fine both ways) and only on 0.68.0 and onwards.
pd-l2ork
changed the title
Disabling nw2 in 0.68.0 and newer versions prevents closing of child windows and other weird behavior
Disabling nw2 in 0.68.0 and newer versions makes "x" button in the window (on all OSs) not trigger close events equivalent to that of the "Close" option in the menu
Nov 8, 2022
Issue Type
Before opening an issue, please search and see if it has already been raised.
Bug Report
Feature Request
Successfully reproduced against the latest version of NW.js?
Current/Missing Behavior
Up until 0.67.1 with nw2 disabled when closing a window by clicking on the "x" button on the window bar would trigger the same close events as pressing CMD/CTRL+W or clicking on Close option inside the File menu. On 0.68.0 and newer this is not the case anymore. This is not the problem with nw2. Only when nw2 is disabled.
Expected/Proposed Behavior
Closing the window using the "x" button in the window bar should trigger the same close events.
Additional Info
It should be simple to reproduce. Just create a close event that should be triggered when closing the windo w and notice how it is not being triggered when closing the window using the "x" button located on the window's top bar.
Given the major slowdown with the use of the nw2 and scripting (see #7 the fix for this is a must since the slowdown makes nw2 currently not comparable/usable when compared to nw1).
Also, I just realized that this is a duplicate of #7981, so I am closing this one.
The text was updated successfully, but these errors were encountered: