Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Change channel events so that created_on is db time and is included in queued task payload #667

Merged
merged 1 commit into from
Dec 4, 2023

Conversation

rowanseymour
Copy link
Member

No description provided.

@rowanseymour rowanseymour requested a review from norkans7 December 4, 2023 19:03
Copy link

codecov bot commented Dec 4, 2023

Codecov Report

Attention: 1 lines in your changes are missing coverage. Please review.

Comparison is base (98ea509) 74.24% compared to head (27ab88f) 74.39%.

Files Patch % Lines
backends/rapidpro/channel_event.go 66.66% 0 Missing and 1 partial ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #667      +/-   ##
==========================================
+ Coverage   74.24%   74.39%   +0.15%     
==========================================
  Files          97       97              
  Lines       13126    13087      -39     
==========================================
- Hits         9745     9736       -9     
+ Misses       2692     2662      -30     
  Partials      689      689              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@rowanseymour rowanseymour merged commit 1445bf8 into main Dec 4, 2023
7 checks passed
@rowanseymour rowanseymour deleted the channel_event_fix branch December 4, 2023 19:13
@github-actions github-actions bot locked and limited conversation to collaborators Dec 4, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants