Use language value in templating metadata instead of trying to match #668
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rowanseymour
commented
Dec 6, 2023
| SendPrep: setSendURL, | ||
| }, | ||
| { | ||
| Label: "Template Country Language", |
There was a problem hiding this comment.
language is now just used as it is so don't need a separate test for en vs en_US etc
rowanseymour
commented
Dec 6, 2023
| SendPrep: setSendURL, | ||
| }, | ||
| { | ||
| Label: "Template Invalid Language", |
rowanseymour
commented
Dec 6, 2023
|
|
||
| import "github.com/nyaruka/gocommon/i18n" | ||
|
|
||
| func GetText(text string, locale i18n.Locale) string { |
There was a problem hiding this comment.
figured might as well make this a generic translation thing
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #668 +/- ##
==========================================
- Coverage 74.39% 74.38% -0.01%
==========================================
Files 97 97
Lines 13087 13082 -5
==========================================
- Hits 9736 9731 -5
Misses 2662 2662
Partials 689 689 ☔ View full report in Codecov by Sentry. |
norkans7
approved these changes
Dec 6, 2023
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This gets rid of trying to match one of our language codes to a known whatsapp language code