Skip to content
Permalink

Comparing changes

Choose two branches to see what’s changed or to start a new pull request. If you need to, you can also or learn more about diff comparisons.

Open a pull request

Create a new pull request by comparing changes across two branches. If you need to, you can also . Learn more about diff comparisons here.
base repository: nytimes/gziphandler
Failed to load repositories. Confirm that selected base ref is valid, then try again.
Loading
base: v1.0.0
Choose a base ref
...
head repository: nytimes/gziphandler
Failed to load repositories. Confirm that selected head ref is valid, then try again.
Loading
compare: master
Choose a head ref
  • 16 commits
  • 6 files changed
  • 9 contributors

Commits on Jan 4, 2018

  1. Copy the full SHA
    063b218 View commit details
  2. Add tests

    juliens authored and jprobinson committed Jan 4, 2018
    Copy the full SHA
    47ca22a View commit details

Commits on Jan 25, 2018

  1. Copy the full SHA
    80d369f View commit details
  2. Copy the full SHA
    4c5b6dc View commit details
  3. Review

    juliens authored and jprobinson committed Jan 25, 2018
    Copy the full SHA
    289a3b8 View commit details

Commits on Feb 21, 2018

  1. Changed minimum size to gzip response

    Added missing test
    zemariamm authored and jprobinson committed Feb 21, 2018
    Copy the full SHA
    a4fca32 View commit details
  2. updated comment

    zemariamm authored and jprobinson committed Feb 21, 2018
    Copy the full SHA
    2600fb1 View commit details

Commits on Feb 27, 2018

  1. Add support for comparing by MIME. (#69)

    * zero API change; don't break current usage.
    * no change in time or space usage using benchmarks
    meirf authored and jprobinson committed Feb 27, 2018
    Copy the full SHA
    5032c88 View commit details

Commits on Aug 14, 2018

  1. Check Content-Length against minSize and passthrough writes if no gzip (

    #71)
    
    Currently there's no way to generate a HEAD response with the correct
    headers as the GET unless you set the minSize as 0, but then gzip headers
    will be written in Close. Instead, allow a Write(nil) that will set the
    correct headers based on the Content-Length/Content-Type headers and only
    initialize a writer if there is a non-zero-length Write. If the
    Content-Length cannot be determined, you cannot generate the response
    because it cannot know if minSize would've been met.
    
    Additionally, if we determined that the request should not be compressed
    we should passthrough writes immediately rather than waiting until
    Close.
    
    Fixes #70
    Fixes #64
    jameshartig authored and jprobinson committed Aug 14, 2018
    Copy the full SHA
    c551b6c View commit details
  2. ADD: install method (#72)

    AlphaWong authored and jprobinson committed Aug 14, 2018
    Copy the full SHA
    4484167 View commit details

Commits on Aug 16, 2018

  1. Copy the full SHA
    edf8477 View commit details

Commits on Aug 20, 2018

  1. Start plain response as soon as certain (#74)

    * Start plain response as soon as it's certain
    
    When we get the response headers it might be pretty
    much already known whether we will have to serve plain
    content instead of gzipping. That is either when
    the content-length header is set with a small enough size,
    there is already an encoding in the response or the
    content-type is already set to a content we don't handle.
    
    * Make Flush work also for non-gzipped responses
    victorges authored and jprobinson committed Aug 20, 2018
    Copy the full SHA
    253f1ac View commit details

Commits on Feb 11, 2019

  1. Ensure org name in the import path is always NYTimes (#76)

    * Add go.mod
    
    * readme: make sure docs always use NYTimes
    
    * Add a canonical import path
    
    This is in prep for the org rename.
    
    * readme: fix license link
    fsouza authored Feb 11, 2019
    Copy the full SHA
    ae3e73a View commit details
  2. travis: refresh the pipeline (#77)

    - incorporate go modules
    - use 1.x to make sure we always use latest version of go
    - enable the race detector in tests
    fsouza authored Feb 11, 2019
    Copy the full SHA
    b8a1976 View commit details

Commits on Feb 21, 2019

  1. Change required go version to 1.11 (#80)

    jared2501 authored and fsouza committed Feb 21, 2019
    Copy the full SHA
    dd04395 View commit details

Commits on Nov 13, 2019

  1. doc: fix typo in gzip.go (#92)

    * doc: fix typo in gzip.go
    
    * using the proper tense
    
    thanks for finding this!
    genofire authored and jprobinson committed Nov 13, 2019
    Copy the full SHA
    2f8bb1d View commit details
Loading