Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Dummy proofs don't support advanced proof system features #1939

Open
mitschabaude opened this issue Dec 4, 2024 · 0 comments
Open

Dummy proofs don't support advanced proof system features #1939

mitschabaude opened this issue Dec 4, 2024 · 0 comments

Comments

@mitschabaude
Copy link
Collaborator

mitschabaude commented Dec 4, 2024

There's no way to pass feature flags or lookup config to dummy proofs. This means a dummy proof will trigger an assert when used as input to a recursive proof, even if the recursive proof doesn't verify it.

Dummy proofs are an important pattern that enables collapsing base case and recursive case into the same method, which is more efficient than having two separate methods. So it'd be nice to add feature flags etc to dummy proofs in Pickles, and automatically pass in the correct feature flags from o1js.

For reference, the assertion that a dummy proof currently triggers (when representing a zkprogram with some feature flags set to true) is this one:
https://github.com/MinaProtocol/mina/blob/86135da5c95a07690218aabdae19d318c3bae27c/src/lib/pickles_types/plonk_types.ml#L398

From trying to hack around that, I know that this is not the only problem -- there is another assertion which seems to be related to the lookup config of the proof, triggered here somehow: src/mina/src/lib/pickles/plonk_checks/scalars.ml:3387:32

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant